Re: [PATCH v8 3/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The global `maxItems: 1` constraint on the `interrupts` property prevents the `mediatek,mt6795-pinctrl` compatible from specifying its two supported hardware interrupts.
--

commit 21e9f5d9b0c26d0a8f4207afe5723d54c0b4b7e6
Author: Yassine Oudjana <y.oudjana@protonmail.com>

dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795

This commit combines the MT6795 pin controller document into the MT6779
binding. It uses conditionals to define valid values for properties like
interrupts and drive-strength for each hardware variant.

> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> index 4dc9504e24ad5..2124804c88631 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml

[ ... ]

> @@ -81,6 +83,45 @@ allOf:
>              - const: iocfg_lt
>              - const: iocfg_tl
>              - const: eint

[ ... ]

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mediatek,mt6795-pinctrl
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +          maxItems: 2
> +
> +        reg-names:
> +          items:
> +            - const: base
> +            - const: eint
> +
> +        interrupts:
> +          minItems: 1
> +          items:
> +            - description: EINT interrupt
> +            - description: EINT event_b interrupt

[Severity: Medium]
Will this conditional block fail schema validation due to the global interrupts
definition?

The top-level interrupts property in this file enforces a global maxItems: 1
limit for all compatibles:

properties:
  interrupts:
    maxItems: 1
    description: ...

Because JSON schema constraints are additive, allowing two items here for
mediatek,mt6795-pinctrl won't override the global maxItems: 1 limit. This
causes device trees like mt6795.dtsi (which specifies two interrupts
for pio: pinctrl@10005000) to fail validation. Should the global maximum
limit be relaxed to maxItems: 2 so this variant can use both interrupts?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530145800.1029920-1-y.oudjana@protonmail.com?part=3