Re: [PATCH v5 RESEND 2/5] arm64: dts: sophgo: add initial Milk-V Duo S board support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree enables several hardware peripherals (emmc, gmac0, i2c4, mdio, sdhci0, sdhci1, spi3, uart0) without defining or assigning their required pinctrl configurations.
--

commit 562d6189b640dfe9eda31b9948bcc49d22497758
Author: Joshua Milas <josh.milas@gmail.com>

arm64: dts: sophgo: add initial Milk-V Duo S board support

Adds initial arm64 support for the Milk-V Duo S board making it possible
to boot Linux to the command line.

Link: https://milkv.io/duo-s [1]

> diff --git a/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
> new file mode 100644
> index 0000000000000..8632470f43ab0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts

[ ... ]

> +&dmac {
> +	status = "okay";
> +};
> +
> +&emmc {
> +	bus-width = <4>;
> +	no-1-8-v;
> +	cap-mmc-hw-reset;
> +	no-sd;
> +	no-sdio;
> +	non-removable;
> +	status = "okay";
> +};

[Severity: Medium]
Should these hardware peripherals have their pinctrl configurations defined?

Several nodes are enabled here (emmc, gmac0, i2c4, mdio, sdhci0, sdhci1,
spi3, uart0) without pinctrl-0 and pinctrl-names properties assigned.

Without these properties, the kernel will not initialize the pin
multiplexing and relies entirely on the bootloader to have set up the
pinmux correctly.

If the bootloader behavior changes, or if a driver attempts to manage power
states by suspending and resuming the device, these peripherals might fail
to function.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530173347.33533-1-josh.milas@gmail.com?part=2