Re: [PATCH v5 RESEND 5/5] riscv64: dts: sophgo: add initial Milk-V Duo S board support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing `pinctrl-0` properties for enabled peripherals, relying unsafely on bootloader pin multiplexing.
- [Medium] Unstable device enumeration due to incomplete MMC aliases.
--

commit 28d2e18610b4be21ce587f3639e449ae96302be3
Author: Joshua Milas <josh.milas@gmail.com>

riscv64: dts: sophgo: add initial Milk-V Duo S board support
    
This adds initial riscv support for the Milk-V Duo S board, making it
possible to boot Linux to the command line.
    
Link: https://milkv.io/duo-s [1]

> diff --git a/arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts b/arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts
> new file mode 100644
> index 0000000000000..8632470f43ab0
> --- /dev/null
> +++ b/arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts
> @@ -0,0 +1,85 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/dts-v1/;
> +
> +#include "sg2000.dtsi"
> +
> +/ {
> +	model = "Milk-V Duo S";
> +	compatible = "milkv,duo-s", "sophgo,sg2000";
> +
> +	aliases {
> +		i2c4 = &i2c4;
> +		mmc0 = &sdhci0;

[Severity: Medium]
Will omitting aliases for the other enabled MMC controllers (&emmc and
&sdhci1) cause unstable device enumeration? 

The Linux MMC core relies on these aliases for stable block device numbering
(/dev/mmcblkX). Without explicit aliases for all enabled controllers, their
indices might be assigned dynamically based on asynchronous probe ordering,
which could swap block device numbers unexpectedly across reboots.

> +		serial0 = &uart0;
> +		spi3 = &spi3;
> +	};

[ ... ]

> +&emmc {
> +	bus-width = <4>;
> +	no-1-8-v;
> +	cap-mmc-hw-reset;
> +	no-sd;
> +	no-sdio;
> +	non-removable;
> +	status = "okay";
> +};

[Severity: Medium]
Do the peripherals enabled in this device tree, such as &emmc, &sdhci0, and
&uart0, need pinctrl-0 properties to define their hardware pin states?

Relying entirely on the bootloader's initial pin multiplexing configuration 
can break power management features like suspend and resume, or impact system
stability if the kernel needs to restore pin parameters dynamically.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530173347.33533-1-josh.milas@gmail.com?part=5