Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joshua Milas" <josh.milas@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 RESEND 4/5] riscv64: dts: sophgo: add SG2000 dtsi
Date: Sat, 30 May 2026 17:56:43 +0000	[thread overview]
Message-ID: <20260530175643.8FFC41F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260530173347.33533-5-josh.milas@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect memory size specification for SG2000 SoC (256 MiB instead of 512 MiB).
--

commit c5b4a9fd5a4e96c34400baa5e56b2ce675d91e7b
Author: Joshua Milas <josh.milas@gmail.com>

riscv64: dts: sophgo: add SG2000 dtsi

This commit introduces the device tree source include file for the Sophgo
SG2000 SoC for the RISC-V architecture.

> diff --git a/arch/riscv/boot/dts/sophgo/sg2000.dtsi b/arch/riscv/boot/dts/sophgo/sg2000.dtsi
> index 0000000000000..412adacc00576
> --- /dev/null
> +++ b/arch/riscv/boot/dts/sophgo/sg2000.dtsi
[ ... ]
> +/ {
> +	compatible = "sophgo,sg2000";
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x80000000 0x10000000>;

[Severity: Medium]
Should this memory capacity be 512 MiB instead of 256 MiB? The SG2000 SoC
is a System-in-Package that integrates 512 MiB of DRAM, and the ARM64 device
tree for the same SoC specifies 0x20000000. 

Setting this to 0x10000000 restricts the available RAM to 256 MiB unless it
is explicitly overridden by a bootloader.

> +	};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530173347.33533-1-josh.milas@gmail.com?part=4

  reply	other threads:[~2026-05-30 17:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 17:33 [PATCH v5 RESEND 0/5] Add initial Milk-V Duo S board support Joshua Milas
2026-05-30 17:33 ` [PATCH v5 RESEND 1/5] dt-bindings: soc: sophgo: add Milk-V Duo S board compatibles Joshua Milas
2026-05-30 17:33 ` [PATCH v5 RESEND 2/5] arm64: dts: sophgo: add initial Milk-V Duo S board support Joshua Milas
2026-05-30 17:46   ` sashiko-bot
2026-05-30 22:01   ` Inochi Amaoto
2026-05-30 17:33 ` [PATCH v5 RESEND 3/5] dt-bindings: soc: sophgo: add sg2000 plic and clint documentation Joshua Milas
2026-05-30 17:33 ` [PATCH v5 RESEND 4/5] riscv64: dts: sophgo: add SG2000 dtsi Joshua Milas
2026-05-30 17:56   ` sashiko-bot [this message]
2026-05-30 17:33 ` [PATCH v5 RESEND 5/5] riscv64: dts: sophgo: add initial Milk-V Duo S board support Joshua Milas
2026-05-30 18:02   ` sashiko-bot
2026-05-30 22:00   ` Inochi Amaoto
2026-05-30 22:02 ` [PATCH v5 RESEND 0/5] Add " Inochi Amaoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260530175643.8FFC41F00898@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=josh.milas@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox