From: sashiko-bot@kernel.org
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: wsa+renesas@sang-engineering.com, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3] arm64: renesas: r8a779g0: add MFIS node
Date: Tue, 02 Jun 2026 15:43:39 +0000 [thread overview]
Message-ID: <20260602154339.8327B1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260602153504.302388-2-wsa+renesas@sang-engineering.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `mfis` node violates unit-address sorting conventions within the `soc` node.
--
commit 103116fe94a9708e753fa97a039cb6fb2fa2c53c
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
arm64: renesas: r8a779g0: add MFIS node
This commit describes the MFIS core used for inter-processor communication
on the Renesas R-Car V4H SparrowHawk board. It adds the mfis node and its
associated interrupts to the device tree.
> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> index 82a7278836e57..3cff822fc609a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -603,6 +603,23 @@ tsn0: ethernet@e6460000 {
> status = "disabled";
> };
>
> + mfis: system-controller@e6260000 {
[Severity: Low]
This isn't a bug, but should this node be placed before the
tsn0: ethernet@e6460000 node to maintain ascending unit-address order?
The unit address 0xe6260000 is lower than 0xe6460000, and standard
Device Tree conventions usually require sorting nodes sequentially.
> + compatible = "renesas,r8a779g0-mfis";
> + reg = <0 0xe6260000 0 0x10000>;
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260602153504.302388-2-wsa+renesas@sang-engineering.com?part=1
next prev parent reply other threads:[~2026-06-02 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 15:32 [PATCH v3] arm64: renesas: r8a779g0: add MFIS node Wolfram Sang
2026-06-02 15:43 ` sashiko-bot [this message]
2026-06-02 18:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602154339.8327B1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox