Devicetree
 help / color / mirror / Atom feed
* [PATCH v3] arm64: renesas: r8a779g0: add MFIS node
@ 2026-06-02 15:32 Wolfram Sang
  2026-06-02 15:43 ` sashiko-bot
  2026-06-02 18:20 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2026-06-02 15:32 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

Describe the MFIS core which is used for various tasks including
inter-processor communication. Interrupt numbers look irregular but they
all work as expected on a Renesas R-Car V4H SparrowHawk board.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Changes since v2:
* increased reg size to 0x10000 (Thanks, Geert!)
* shortened interrupt-names line length (Thanks, Geert!)

 arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
index 82a7278836e5..3cff822fc609 100644
--- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
@@ -603,6 +603,23 @@ tsn0: ethernet@e6460000 {
 			status = "disabled";
 		};
 
+		mfis: system-controller@e6260000 {
+			compatible = "renesas,r8a779g0-mfis";
+			reg = <0 0xe6260000 0 0x10000>;
+			reg-names = "common";
+			interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 129 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 916 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 918 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 920 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 922 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch0e", "ch1e", "ch2e", "ch3e", "ch4e", "ch5e", "ch6e", "ch7e",
+					  "ch8e", "ch9e", "ch10e", "ch11e";
+			#hwlock-cells = <1>;
+			#mbox-cells = <2>;
+			status = "disabled";
+		};
+
 		i2c0: i2c@e6500000 {
 			compatible = "renesas,i2c-r8a779g0",
 				     "renesas,rcar-gen4-i2c";
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] arm64: renesas: r8a779g0: add MFIS node
  2026-06-02 15:32 [PATCH v3] arm64: renesas: r8a779g0: add MFIS node Wolfram Sang
@ 2026-06-02 15:43 ` sashiko-bot
  2026-06-02 18:20 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-06-02 15:43 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: wsa+renesas, devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `mfis` node violates unit-address sorting conventions within the `soc` node.
--

commit 103116fe94a9708e753fa97a039cb6fb2fa2c53c
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
arm64: renesas: r8a779g0: add MFIS node

This commit describes the MFIS core used for inter-processor communication
on the Renesas R-Car V4H SparrowHawk board. It adds the mfis node and its
associated interrupts to the device tree.

> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> index 82a7278836e57..3cff822fc609a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -603,6 +603,23 @@ tsn0: ethernet@e6460000 {
>  			status = "disabled";
>  		};
>  
> +		mfis: system-controller@e6260000 {

[Severity: Low]
This isn't a bug, but should this node be placed before the 
tsn0: ethernet@e6460000 node to maintain ascending unit-address order? 
The unit address 0xe6260000 is lower than 0xe6460000, and standard 
Device Tree conventions usually require sorting nodes sequentially.

> +			compatible = "renesas,r8a779g0-mfis";
> +			reg = <0 0xe6260000 0 0x10000>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602153504.302388-2-wsa+renesas@sang-engineering.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] arm64: renesas: r8a779g0: add MFIS node
  2026-06-02 15:32 [PATCH v3] arm64: renesas: r8a779g0: add MFIS node Wolfram Sang
  2026-06-02 15:43 ` sashiko-bot
@ 2026-06-02 18:20 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2026-06-02 18:20 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

On Tue, Jun 02, 2026 at 05:32:22PM +0200, Wolfram Sang wrote:
> Describe the MFIS core which is used for various tasks including
> inter-processor communication. Interrupt numbers look irregular but they
> all work as expected on a Renesas R-Car V4H SparrowHawk board.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Damn, messed up the ordering again :( Sorry, seems I did too many things
in parallel today...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-02 18:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 15:32 [PATCH v3] arm64: renesas: r8a779g0: add MFIS node Wolfram Sang
2026-06-02 15:43 ` sashiko-bot
2026-06-02 18:20 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox