Re: [PATCH 1/2] dt-binding: hwmon: Add binding for ADT7462

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete binding migration: `onnn,adt7462` is not migrated to the new schema and remains in `trivial-devices.yaml`.
--

commit 8e3b73cf675c7a9534a713ae61c15469f85f0d06
Author: Kory Maincent <kory.maincent@bootlin.com>

dt-binding: hwmon: Add binding for ADT7462

This commit adds the ADT7462 hwmon Controller device tree bindings
documentation.

> diff --git a/Documentation/devicetree/bindings/hwmon/adt7462.yaml b/Documentation/devicetree/bindings/hwmon/adt7462.yaml
> new file mode 100644
> index 0000000000000..745a371affd65
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adt7462.yaml
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adt7462

[Severity: Medium]
Should the existing onnn,adt7462 compatible string be migrated into this
new schema?

The ADT7462 device is already documented in trivial-devices.yaml under
the compatible string onnn,adt7462, which is actively used in existing
device trees.

By introducing this new schema without including onnn,adt7462 and without
removing it from trivial-devices.yaml, existing device trees will not
benefit from the detailed schema validation. This also leaves the subsystem
with two conflicting, fragmented representations of the same hardware.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-adt7462-bindings-v1-0-301304bcf774@bootlin.com?part=1