Re: [PATCH 2/2] hwmon: (adt7462) Add of_match_table to support devicetree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Using `of_match_ptr()` prevents the driver from being matched via ACPI PRP0001 when `CONFIG_OF` is disabled.
--

commit c2691e00dcd763957c6a2291880ea9079be2bbda
Author: Kory Maincent <kory.maincent@bootlin.com>

hwmon: (adt7462) Add of_match_table to support devicetree

This commit adds an of_match_table to the adt7462 driver to enable
devicetree probing.

> diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c
> index 174dfee47f7a7..ef6e5252dc0a4 100644
> --- a/drivers/hwmon/adt7462.c
> +++ b/drivers/hwmon/adt7462.c
[ ... ]
> @@ -1814,10 +1814,17 @@ static const struct i2c_device_id adt7462_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, adt7462_id);
>  
> +static const struct of_device_id __maybe_unused adt7462_of_match[] = {
> +	{ .compatible = "adi,adt7462" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, adt7462_of_match);
> +
>  static struct i2c_driver adt7462_driver = {
>  	.class		= I2C_CLASS_HWMON,
>  	.driver = {
>  		.name	= "adt7462",
> +		.of_match_table = of_match_ptr(adt7462_of_match),

[Severity: Low]
Does using of_match_ptr() here prevent the driver from being matched via
ACPI PRP0001 when CONFIG_OF is disabled?

When CONFIG_OF is disabled, of_match_ptr() evaluates to NULL, hiding the
of_match_table from the driver core. This prevents the driver from being
matched using ACPI PRP0001, which relies on OF compatible strings even on
systems without Device Tree.

Would it be better to drop of_match_ptr() and assign the table directly,
along with removing the __maybe_unused attribute from adt7462_of_match?

>  	},
>  	.probe		= adt7462_probe,
>  	.id_table	= adt7462_id,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-adt7462-bindings-v1-0-301304bcf774@bootlin.com?part=2