Re: [PATCH 1/2] dt-binding: hwmon: Add binding for ADT7462

[Romain Gantois <romain.gantois@bootlin.com>]

[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]

On Wednesday, 3 June 2026 13:35:25 CEST sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider: - [Medium] Incomplete binding migration:
> `onnn,adt7462` is not migrated to the new schema and remains in
> `trivial-devices.yaml`. --
> 
> commit 8e3b73cf675c7a9534a713ae61c15469f85f0d06
> Author: Kory Maincent <kory.maincent@bootlin.com>
> 
> dt-binding: hwmon: Add binding for ADT7462
> 
> This commit adds the ADT7462 hwmon Controller device tree bindings
> documentation.
> 
> > diff --git a/Documentation/devicetree/bindings/hwmon/adt7462.yaml
> > b/Documentation/devicetree/bindings/hwmon/adt7462.yaml new file mode
> > 100644
> > index 0000000000000..745a371affd65
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/adt7462.yaml
> 
> [ ... ]
> 
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,adt7462
> 
> [Severity: Medium]
> Should the existing onnn,adt7462 compatible string be migrated into this
> new schema?
> 
> The ADT7462 device is already documented in trivial-devices.yaml under
> the compatible string onnn,adt7462, which is actively used in existing
> device trees.
> 
> By introducing this new schema without including onnn,adt7462 and without
> removing it from trivial-devices.yaml, existing device trees will not
> benefit from the detailed schema validation. This also leaves the subsystem
> with two conflicting, fragmented representations of the same hardware.

I've just done a bit of research and it looks like this component is now 
commercialized by Onsemi, so the existing compatible would be the correct one.

Furthermore, the suggested binding only has a "reg" property and a 
"compatible" property, so it seems like the trivial-devices binding is enough 
to describe it for now.

I'll drop patch 1/2 in version 2.

Thanks,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]