Re: [PATCH v3 3/5] dt-bindings: clock: Move xlnx,zynqmp-clk to its own schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The dt-bindings example in `xlnx,versal-clk.yaml` fails schema validation (`dt_binding_check`) because it incorrectly pairs an `xlnx,zynqmp-firmware` parent with an `xlnx,versal-clk` clock controller.
--

commit eb45bdb29d194f45db74a8a016c6af5c112a380b
Author: Michal Simek <michal.simek@amd.com>

dt-bindings: clock: Move xlnx,zynqmp-clk to its own schema

This commit moves the ZynqMP clock controller binding to a dedicated 
xlnx,zynqmp-clk.yaml schema, separating it from the Versal bindings. It 
updates the xlnx,zynqmp-firmware.yaml schema to enforce the appropriate 
clock-controller child node based on the selected firmware compatibility.

> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 680082c29f016..72af37cdb103b 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml

[ ... ]

> @@ -113,10 +112,14 @@ allOf:
>              const: xlnx,zynqmp-firmware
>      then:
>        properties:
> +        clock-controller:
> +          $ref: /schemas/clock/xlnx,zynqmp-clk.yaml#

[Severity: Low]
Will this new rule cause the example in xlnx,versal-clk.yaml to fail 
dt_binding_check? 

The remaining example in 
Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml defines a 
clock-controller with compatible = "xlnx,versal-clk" under a firmware 
node with compatible = "xlnx,zynqmp-firmware":

    firmware {
      zynqmp_firmware: zynqmp-firmware {
        compatible = "xlnx,zynqmp-firmware";
        ...
        versal_clk: clock-controller {
          compatible = "xlnx,versal-clk";

Because this new conditional rule enforces that an xlnx,zynqmp-firmware 
parent must have an xlnx,zynqmp-clk child, the xlnx,versal-clk example 
might now be invalid. Does the example need to be updated to use 
compatible = "xlnx,versal-firmware" to match the child controller?

>          pinctrl:
>            $ref: /schemas/pinctrl/xlnx,zynqmp-pinctrl.yaml#

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780499520.git.michal.simek@amd.com?part=3