Re: [PATCH net-next v2 01/14] dt-bindings: net: qca,qca808x: Add regulator properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree example incorrectly assigns a 1.8V regulator phandle to a 1.05V supply property.
--

commit 9408235f22241ddbd72a22ee2611a98eece3d7f2
Author: Daniel Thompson <daniel@riscstar.com>

dt-bindings: net: qca,qca808x: Add regulator properties

This commit adds four power rail supply properties (avdd18, vdd, vdd18, and 
vdd125) to the QCA808x ethernet PHY device tree binding. It also updates the 
example section to demonstrate how to configure the power supplies.

> diff --git a/Documentation/devicetree/bindings/net/qca,qca808x.yaml b/Documentation/devicetree/bindings/net/qca,qca808x.yaml
> index e2552655902a3..3c1b7eca33caf 100644
> --- a/Documentation/devicetree/bindings/net/qca,qca808x.yaml
> +++ b/Documentation/devicetree/bindings/net/qca,qca808x.yaml
[ ... ]
> @@ -25,6 +25,18 @@ properties:
>      enum:
>        - ethernet-phy-id004d.d101
>  
> +  avdd18-supply:
> +    description: 1.8v analog power supply.
> +
> +  vdd-supply:
> +    description: 1.05v power supply.
> +
[ ... ]
> @@ -39,6 +51,8 @@ examples:
>              compatible = "ethernet-phy-id004d.d101";
>              reg = <0>;
>  
> +            vdd-supply = <&phy_vreg_1v8>;
> +

[Severity: Low]
Is this the intended phandle for the vdd-supply property in this example?

The property description defines vdd-supply as a 1.05v power supply, but the
example assigns what appears to be a 1.8v regulator (&phy_vreg_1v8) to it.
Could this discrepancy lead developers to copy-paste an overvoltage
configuration into their actual board device trees?

>              leds {
>                  #address-cells = <1>;
>                  #size-cells = <0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605010022.968612-1-elder@riscstar.com?part=1