Re: [PATCH v2 1/4] dt-bindings: mfd: syscon: Disallow simple-bus with syscon

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] DT Binding Violation: Undocumented Compatibles and Validation Breakage
--

commit 73d2cc9a54e99039c48884fc1ade73467dc1c67d
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: mfd: syscon: Disallow simple-bus with syscon

This commit adds a schema rule to disallow the combination of syscon and
simple-bus compatibles. It creates exceptions for existing upstream device
trees that already use this pattern. It also introduces new compatibles for
several TI platforms to bypass this restriction without a dedicated schema.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon-common.yaml b/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> index 14a08e7bc8bdd..315357da146ea 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> @@ -57,6 +57,38 @@ allOf:
>            minItems: 3
>            maxItems: 5
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: simple-bus
> +    then:
> +      # simple-bus conflicts with syscon - if a device is a system controller
> +      # with miscellaneous registers, then it has at least one dedicated
> +      # function thus it is not a simple bus. Allow existing exceptions.
> +      if:
> +        properties:
> +          compatible:
> +            not:
> +              contains:
> +                # This list CANNOT grow
> +                enum:
> +                  - cznic,turris1x-cpld
> +                  - img,pistachio-cr-periph
> +                  - ti,am3352-scm-conf
> +                  - ti,am4372-scm-conf

[Severity: Medium]
Does this cause make dtbs_check to report undocumented compatible warnings
for the newly added TI platforms?

Since these new compatibles are introduced in this exclusion list but are
not defined under a standard properties compatible block in syscon.yaml
or another dedicated schema, it appears the tooling will fail to extract
them. Will this lead to schema validation skipping hardware-specific
constraints for these TI platforms?

> +                  - ti,dm814-scm-conf
> +                  - ti,dm8168-scm-conf
> +                  - ti,dra7-scm-conf
> +                  - ti,omap2-scm-conf
> +                  - ti,omap3-scm-conf
> +                  - ti,omap4-sysc-padconf-global
> +                  - ti,omap5-scm-conf
> +                  - ti,omap5-scm-wkup-conf
> +      then:
> +        required:
> +          - incorrect-usage-of-simple-bus-and-syscon

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-n-dt-bindings-simple-bus-syscon-v2-0-0203e6c249dc@oss.qualcomm.com?part=1