Re: [PATCH v2 3/4] dt-bindings: mfd: syscon: Drop custom select for older dtschema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removal of the custom `select` block breaks device tree validation for `dtschema` versions older than 2024.02, which are still permitted by the kernel build system.
--

commit f0ac964d90c2fab365a733b219f9d7ce636b7fb6
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: mfd: syscon: Drop custom select for older dtschema

This commit removes a custom select block from the syscon binding that was
previously required for compatibility with dtschema versions older than
2024.02. The change aims to reduce duplication and prevent errors when adding
new compatible strings.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..fe882d3f828b1 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -19,122 +19,6 @@ description: |
>  maintainers:
>    - Lee Jones <lee@kernel.org>
>  
> -# Need a select with all compatibles listed for compatibility with older
> -# dtschema (<2024.02), so this will not be selected for other schemas having
> -# syscon fallback.
> -select:
> -  properties:

[Severity: Medium]
Will removing this select block break schema validation for toolchain
versions that are still officially permitted?

Looking at Documentation/devicetree/bindings/Makefile, the minimum
supported version is currently explicitly maintained as:

DT_SCHEMA_MIN_VERSION = 2023.9

Since the kernel build system still officially supports dtschema versions
between 2023.9 and 2024.01, wouldn't dropping this select cause syscon.yaml
to erroneously apply to all syscon nodes and generate false-positive
schema validation failures for users on those older versions?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-n-dt-bindings-simple-bus-syscon-v2-0-0203e6c249dc@oss.qualcomm.com?part=3