Re: [PATCH v2 4/4] ARM: dts: ti: Add specific compatibles for SCM conf nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible `ti,omap5-scm-conf` is incorrectly and generically assigned to the `omap5_padconf_global` node instead of a dedicated padconf compatible.
--

commit e73bdcc41065ea6e37040a568932068a0bac18ec
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

ARM: dts: ti: Add specific compatibles for SCM conf nodes

This commit adds specific compatible strings to the syscon SCM conf nodes
across several TI SoCs to comply with writing-bindings.rst rules, and to
resolve a contradiction between "syscon" and "simple-bus".

> diff --git a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
> index 915870eb5c990..3350128db22df 100644
> --- a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
[ ... ]
> @@ -96,8 +96,7 @@ omap5_pmx_core: pinmux@40 {
>  				};
>  
>  				omap5_padconf_global: omap5_padconf_global@5a0 {
> -					compatible = "syscon",
> -						     "simple-bus";
> +					compatible = "ti,omap5-scm-conf", "syscon", "simple-bus";

[Severity: Low]
Should this node use a dedicated padconf compatible string similar to the
OMAP4 implementation? The OMAP4 equivalent correctly received
"ti,omap4-sysc-padconf-global", but here the generic "ti,omap5-scm-conf" is
being applied to the padconf global node, which creates a semantic mismatch
with the actual SCM conf node.

>  					reg = <0x5a0 0xec>;
>  					#address-cells = <1>;
>  					#size-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-n-dt-bindings-simple-bus-syscon-v2-0-0203e6c249dc@oss.qualcomm.com?part=4