Re: [PATCH v3 1/5] dt-bindings: soc: cix,sky1-system-control: add audss system control

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `clock-controller` child node in the `cix,sky1-audss-system-control` example completely omits `#clock-cells` and other properties (`clocks`, `clock-names`, `resets`, `power-domains`) required by its schema. According to subsystem guidelines, the `examples` section must include all required properties to pass schema validation.
--

commit f2cf10fde483506768695633b3e23cc67dd4acf0
Author: Joakim Zhang <joakim.zhang@cixtech.com>

dt-bindings: soc: cix,sky1-system-control: add audss system control

This commit adds a new compatible string cix,sky1-audss-system-control to the
cix,sky1-system-control device tree binding schema. It represents the Sky1
audio subsystem system control block, which acts as a syscon parent and
simple-mfd for audio-related clocks and resets. It also adds a new reset indices
header file for the software resets.

> diff --git a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> --- a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml

[ ... ]

> @@ -40,3 +67,13 @@ examples:
>        reg = <0x4160000 0x100>;
>        #reset-cells = <1>;
>      };
> +  - |
> +    audss_syscon: system-controller@7110000 {
> +        compatible = "cix,sky1-audss-system-control", "simple-mfd", "syscon";
> +        reg = <0x7110000 0x10000>;
> +        #reset-cells = <1>;
> +
> +        clock-controller {
> +            compatible = "cix,sky1-audss-clock";
> +        };

[Severity: Low]
Are required properties like #clock-cells, clocks, clock-names, resets, and
power-domains omitted from this clock-controller child node?

According to subsystem guidelines, the examples section must include all
required properties to pass schema validation. Will this incomplete node cause a
regression during make dt_binding_check when the example is evaluated against
the cix,sky1-audss-clock schema?

> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610061712.3203984-1-joakim.zhang@cixtech.com?part=1