From: Lee Jones <lee@kernel.org>
To: "Duje Mihanović" <dujemihanovic32@gmail.com>
Cc: Karel Balej <balejk@matfyz.cz>,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/3] mfd: 88pm886: Initialize battery page
Date: Wed, 10 Jun 2026 11:58:41 +0100 [thread overview]
Message-ID: <20260610105841.GK4151951@google.com> (raw)
In-Reply-To: <ZyFElwT1QjOADA-7NXdGRw@gmail.com>
On Mon, 08 Jun 2026, Duje Mihanović wrote:
> On Monday, 8 June 2026 10:55:24 Central European Summer Time Lee Jones wrote:
> > On Sun, 07 Jun 2026, Duje Mihanović wrote:
>
> [...]
>
> > > Lee, do you by chance know how to proceed here?
> >
> > You can move them.
> >
> > Please take into consideration data-size as well, rather than blindly
> > following RCT. Larger items (structs) at the top down to smaller (ints
> > and bools) as the bottom. Luckily the larger (data size) items also end
> > up being longer (string).
>
> Am I to consider the sizes of the pointers or the structs they point to?
No - group all structs in RCT.
--
Lee Jones
next prev parent reply other threads:[~2026-06-10 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 19:14 [PATCH 0/3] 88PM886 Vbus regulator support Duje Mihanović
2026-05-26 19:14 ` [PATCH 1/3] dt-bindings: mfd: 88pm886: Allow vbus regulator Duje Mihanović
2026-05-27 15:05 ` Conor Dooley
2026-06-07 11:03 ` Karel Balej
2026-05-26 19:14 ` [PATCH 2/3] mfd: 88pm886: Initialize battery page Duje Mihanović
2026-06-07 10:19 ` Karel Balej
2026-06-07 14:19 ` Duje Mihanović
2026-06-08 8:55 ` Lee Jones
2026-06-08 10:10 ` Duje Mihanović
2026-06-10 10:58 ` Lee Jones [this message]
2026-05-26 19:14 ` [PATCH 3/3] regulator: 88pm886: Add Vbus regulator Duje Mihanović
2026-05-26 20:02 ` sashiko-bot
2026-06-07 10:44 ` Karel Balej
2026-06-07 14:02 ` Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610105841.GK4151951@google.com \
--to=lee@kernel.org \
--cc=balejk@matfyz.cz \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dujemihanovic32@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox