Re: [PATCH v2 1/2] spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces 'snps,dwc-ssi-2.00a' as a fallback compatible string but does not document it as a standalone generic compatible.
--

commit a0b5bdaa0ec7a10bb2b844ee5ff0f01be111deee
Author: Changhuang Liang <changhuang.liang@starfivetech.com>

spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi

Add a new compatible string "starfive,jhb100-spi" for the StarFive
JHB100 SPI, it based on the Synopsys DesignWare SSI version 2.00a,
uses snps,dwc-ssi-2.00a as the primary fallback and snps,dwc-ssi-1.01a
as the secondary fallback.

> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index 8ebebcebca160..4458316326fc4 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -54,6 +54,12 @@ properties:
>                - sophgo,sg2042-spi
>                - thead,th1520-spi
>            - const: snps,dw-apb-ssi
> +      - description: Vendor controllers which use snps,dwc-ssi-2.00a as fallback
> +        items:
> +          - enum:
> +              - starfive,jhb100-spi
> +          - const: snps,dwc-ssi-2.00a
> +          - const: snps,dwc-ssi-1.01a

[Severity: Medium]
Since snps,dwc-ssi-2.00a is introduced as a fallback here, should it also be
added as a valid standalone string under the "Generic DW SPI Controller" enum
list earlier in properties:compatible:oneOf?

If it is omitted from the generic enum list, any future device tree nodes
that use the generic Synopsys 2.00a IP core without a vendor prefix might
fail schema validation.

For context, the existing generic list only contains snps,dwc-ssi-1.01a and
snps,dw-apb-ssi:

  compatible:
    oneOf:
      - description: Generic DW SPI Controller
        enum:
          - snps,dw-apb-ssi
          - snps,dwc-ssi-1.01a

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619143443.22267-1-changhuang.liang@starfivetech.com?part=1