[PATCH v2 0/2] Add support for StarFive JHB100 SPI

[PATCH v2 0/2] Add support for StarFive JHB100 SPI

[Changhuang Liang]

The StarFive JHB100 SPI is based on the Synopsys DesignWare SSI version 2.00.

changes since v1:
PATCH 1:
- Add "starfive,jhb100-spi" and support falling back to
  "snps,dwc-ssi-2.00a" or "snps,dwc-ssi-1.01a".
- using subject lines reflecting the style for the
  spi subsystem.

v1: https://lore.kernel.org/all/20260612125856.8530-1-changhuang.liang@starfivetech.com/

Changhuang Liang (2):
  spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi
  spi: dw: Add support for snps,dwc-ssi-2.00a

 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ++++++
 drivers/spi/spi-dw-mmio.c                                  | 1 +
 2 files changed, 7 insertions(+)

--
2.25.1

[PATCH v2 1/2] spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi

[Changhuang Liang]

Add a new compatible string "starfive,jhb100-spi" for the StarFive
JHB100 SPI, it based on the Synopsys DesignWare SSI version 2.00a,
uses snps,dwc-ssi-2.00a as the primary fallback and snps,dwc-ssi-1.01a
as the secondary fallback.

Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
index 8ebebcebca16..4458316326fc 100644
--- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
+++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
@@ -54,6 +54,12 @@ properties:
               - sophgo,sg2042-spi
               - thead,th1520-spi
           - const: snps,dw-apb-ssi
+      - description: Vendor controllers which use snps,dwc-ssi-2.00a as fallback
+        items:
+          - enum:
+              - starfive,jhb100-spi
+          - const: snps,dwc-ssi-2.00a
+          - const: snps,dwc-ssi-1.01a
       - description: Intel Keem Bay SPI Controller
         const: intel,keembay-ssi
       - description: Intel Mount Evans Integrated Management Complex SPI Controller
-- 
2.25.1

[PATCH v2 2/2] spi: dw: Add support for snps,dwc-ssi-2.00a

[Changhuang Liang]

Add a new compatible entry "snps,dwc-ssi-2.00a" for the Synopsys
DesignWare SSI controller version 2.00a. This variant uses the same
initialization routine as snps,dwc-ssi-1.01a (dw_spi_hssi_init).

Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
 drivers/spi/spi-dw-mmio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index 4fc864d38cff..603e81a92c57 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -438,6 +438,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = {
 	{ .compatible = "amazon,alpine-dw-apb-ssi", .data = dw_spi_alpine_init},
 	{ .compatible = "renesas,rzn1-spi", .data = dw_spi_pssi_init},
 	{ .compatible = "snps,dwc-ssi-1.01a", .data = dw_spi_hssi_init},
+	{ .compatible = "snps,dwc-ssi-2.00a", .data = dw_spi_hssi_init},
 	{ .compatible = "intel,keembay-ssi", .data = dw_spi_hssi_no_dma_init},
 	{
 		.compatible = "intel,mountevans-imc-ssi",
-- 
2.25.1

Re: [PATCH v2 1/2] spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces 'snps,dwc-ssi-2.00a' as a fallback compatible string but does not document it as a standalone generic compatible.
--

commit a0b5bdaa0ec7a10bb2b844ee5ff0f01be111deee
Author: Changhuang Liang <changhuang.liang@starfivetech.com>

spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi

Add a new compatible string "starfive,jhb100-spi" for the StarFive
JHB100 SPI, it based on the Synopsys DesignWare SSI version 2.00a,
uses snps,dwc-ssi-2.00a as the primary fallback and snps,dwc-ssi-1.01a
as the secondary fallback.

> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index 8ebebcebca160..4458316326fc4 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -54,6 +54,12 @@ properties:
>                - sophgo,sg2042-spi
>                - thead,th1520-spi
>            - const: snps,dw-apb-ssi
> +      - description: Vendor controllers which use snps,dwc-ssi-2.00a as fallback
> +        items:
> +          - enum:
> +              - starfive,jhb100-spi
> +          - const: snps,dwc-ssi-2.00a
> +          - const: snps,dwc-ssi-1.01a

[Severity: Medium]
Since snps,dwc-ssi-2.00a is introduced as a fallback here, should it also be
added as a valid standalone string under the "Generic DW SPI Controller" enum
list earlier in properties:compatible:oneOf?

If it is omitted from the generic enum list, any future device tree nodes
that use the generic Synopsys 2.00a IP core without a vendor prefix might
fail schema validation.

For context, the existing generic list only contains snps,dwc-ssi-1.01a and
snps,dw-apb-ssi:

  compatible:
    oneOf:
      - description: Generic DW SPI Controller
        enum:
          - snps,dw-apb-ssi
          - snps,dwc-ssi-1.01a

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619143443.22267-1-changhuang.liang@starfivetech.com?part=1