* [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
@ 2026-05-23 19:25 Marek Vasut
2026-05-23 19:40 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Marek Vasut @ 2026-05-23 19:25 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Brian Masney, Conor Dooley, Geert Uytterhoeven,
Krzysztof Kozlowski, Michael Turquette, Rob Herring, Stephen Boyd,
devicetree, linux-clk, linux-kernel, linux-renesas-soc
Since commit 2abdc3dcf978 ("dt-bindings: clock: renesas,cpg-clocks:
Document ZT/ZTR trace clock on R-Mobile APE6"), the APE6 clock node
expects two additional "clock-output-names" entries, "zt" and "ztr".
Update the example accordingly.
Fixes: 2abdc3dcf978 ("dt-bindings: clock: renesas,cpg-clocks: Document ZT/ZTR trace clock on R-Mobile APE6")
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Brian Masney <bmasney@redhat.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
.../devicetree/bindings/clock/renesas,cpg-div6-clock.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
index 2197c952e21df..b6ee8c8efd46d 100644
--- a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
@@ -60,7 +60,7 @@ examples:
clock-output-names = "main", "pll0", "pll1", "pll2",
"pll2s", "pll2h", "z", "z2",
"i", "m3", "b", "m1", "m2",
- "zx", "zs", "hp";
+ "zx", "zs", "hp", "ztr", "zt";
};
sdhi2_clk: sdhi2_clk@e615007c {
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
2026-05-23 19:25 [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example Marek Vasut
@ 2026-05-23 19:40 ` sashiko-bot
2026-05-25 16:37 ` Conor Dooley
2026-05-25 19:47 ` Conor Dooley
2026-06-24 13:10 ` Rob Herring
2 siblings, 1 reply; 6+ messages in thread
From: sashiko-bot @ 2026-05-23 19:40 UTC (permalink / raw)
To: Marek Vasut; +Cc: robh, wsa+renesas, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding 18 items to `clock-output-names` in the example triggers a `dt_binding_check` schema validation error due to an un-updated top-level constraint in `renesas,cpg-clocks.yaml`.
--
commit aaa0ff6ae07f5974071a547fef4a5b41bc484428
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
This commit updates the R-Mobile APE6 clock node example to include
the "zt" and "ztr" clock-output-names entries. This aligns the example
with the expectations documented in a previous commit.
> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> index 2197c952e21df..b6ee8c8efd46d 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> @@ -60,7 +60,7 @@ examples:
> clock-output-names = "main", "pll0", "pll1", "pll2",
> "pll2s", "pll2h", "z", "z2",
> "i", "m3", "b", "m1", "m2",
> - "zx", "zs", "hp";
> + "zx", "zs", "hp", "ztr", "zt";
[Severity: Low]
Does adding these two items cause a schema validation failure during
dt_binding_check?
The top-level clock-output-names property in renesas,cpg-clocks.yaml has a
maxItems constraint of 17. Adding "ztr" and "zt" here brings the total
item count to 18.
While the underlying limit omission occurred in the earlier commit
2abdc3dcf978, modifying this example to 18 items will now directly
trigger the overarching validation limit error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260523192622.56605-1-marek.vasut+renesas@mailbox.org?part=1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
2026-05-23 19:40 ` sashiko-bot
@ 2026-05-25 16:37 ` Conor Dooley
2026-05-25 19:45 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Conor Dooley @ 2026-05-25 16:37 UTC (permalink / raw)
To: sashiko-reviews; +Cc: Marek Vasut, robh, wsa+renesas, devicetree, conor+dt
[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]
On Sat, May 23, 2026 at 07:40:47PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Adding 18 items to `clock-output-names` in the example triggers a `dt_binding_check` schema validation error due to an un-updated top-level constraint in `renesas,cpg-clocks.yaml`.
> --
>
> commit aaa0ff6ae07f5974071a547fef4a5b41bc484428
> Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
>
> dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
>
> This commit updates the R-Mobile APE6 clock node example to include
> the "zt" and "ztr" clock-output-names entries. This aligns the example
> with the expectations documented in a previous commit.
>
> > diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> > index 2197c952e21df..b6ee8c8efd46d 100644
> > --- a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> > @@ -60,7 +60,7 @@ examples:
> > clock-output-names = "main", "pll0", "pll1", "pll2",
> > "pll2s", "pll2h", "z", "z2",
> > "i", "m3", "b", "m1", "m2",
> > - "zx", "zs", "hp";
> > + "zx", "zs", "hp", "ztr", "zt";
>
> [Severity: Low]
> Does adding these two items cause a schema validation failure during
> dt_binding_check?
>
> The top-level clock-output-names property in renesas,cpg-clocks.yaml has a
> maxItems constraint of 17. Adding "ztr" and "zt" here brings the total
> item count to 18.
>
> While the underlying limit omission occurred in the earlier commit
> 2abdc3dcf978, modifying this example to 18 items will now directly
> trigger the overarching validation limit error.
What does renesas,cpg-clocks.yaml have to do with this?
This is just complete crap, right?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
2026-05-25 16:37 ` Conor Dooley
@ 2026-05-25 19:45 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2026-05-25 19:45 UTC (permalink / raw)
To: Conor Dooley, sashiko-reviews; +Cc: robh, wsa+renesas, devicetree, conor+dt
On 5/25/26 6:37 PM, Conor Dooley wrote:
> On Sat, May 23, 2026 at 07:40:47PM +0000, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>> - [Low] Adding 18 items to `clock-output-names` in the example triggers a `dt_binding_check` schema validation error due to an un-updated top-level constraint in `renesas,cpg-clocks.yaml`.
>> --
>>
>> commit aaa0ff6ae07f5974071a547fef4a5b41bc484428
>> Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>
>> dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
>>
>> This commit updates the R-Mobile APE6 clock node example to include
>> the "zt" and "ztr" clock-output-names entries. This aligns the example
>> with the expectations documented in a previous commit.
>>
>>> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
>>> index 2197c952e21df..b6ee8c8efd46d 100644
>>> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
>>> @@ -60,7 +60,7 @@ examples:
>>> clock-output-names = "main", "pll0", "pll1", "pll2",
>>> "pll2s", "pll2h", "z", "z2",
>>> "i", "m3", "b", "m1", "m2",
>>> - "zx", "zs", "hp";
>>> + "zx", "zs", "hp", "ztr", "zt";
>>
>> [Severity: Low]
>> Does adding these two items cause a schema validation failure during
>> dt_binding_check?
>>
>> The top-level clock-output-names property in renesas,cpg-clocks.yaml has a
>> maxItems constraint of 17. Adding "ztr" and "zt" here brings the total
>> item count to 18.
>>
>> While the underlying limit omission occurred in the earlier commit
>> 2abdc3dcf978, modifying this example to 18 items will now directly
>> trigger the overarching validation limit error.
>
> What does renesas,cpg-clocks.yaml have to do with this?
> This is just complete crap, right?
The example in renesas,cpg-div6-clock.yaml references a binding in
renesas,cpg-clocks.yaml , but the both ingested some nonsensical version
of the later and produced nonsense based on that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
2026-05-23 19:25 [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example Marek Vasut
2026-05-23 19:40 ` sashiko-bot
@ 2026-05-25 19:47 ` Conor Dooley
2026-06-24 13:10 ` Rob Herring
2 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2026-05-25 19:47 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Brian Masney, Conor Dooley, Geert Uytterhoeven,
Krzysztof Kozlowski, Michael Turquette, Rob Herring, Stephen Boyd,
devicetree, linux-clk, linux-kernel, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Sat, May 23, 2026 at 09:25:50PM +0200, Marek Vasut wrote:
> Since commit 2abdc3dcf978 ("dt-bindings: clock: renesas,cpg-clocks:
> Document ZT/ZTR trace clock on R-Mobile APE6"), the APE6 clock node
> expects two additional "clock-output-names" entries, "zt" and "ztr".
> Update the example accordingly.
>
> Fixes: 2abdc3dcf978 ("dt-bindings: clock: renesas,cpg-clocks: Document ZT/ZTR trace clock on R-Mobile APE6")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
2026-05-23 19:25 [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example Marek Vasut
2026-05-23 19:40 ` sashiko-bot
2026-05-25 19:47 ` Conor Dooley
@ 2026-06-24 13:10 ` Rob Herring
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2026-06-24 13:10 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Brian Masney, Conor Dooley, Geert Uytterhoeven,
Krzysztof Kozlowski, Michael Turquette, Stephen Boyd, devicetree,
linux-clk, linux-kernel, linux-renesas-soc
On Sat, May 23, 2026 at 09:25:50PM +0200, Marek Vasut wrote:
> Since commit 2abdc3dcf978 ("dt-bindings: clock: renesas,cpg-clocks:
> Document ZT/ZTR trace clock on R-Mobile APE6"), the APE6 clock node
> expects two additional "clock-output-names" entries, "zt" and "ztr".
> Update the example accordingly.
>
> Fixes: 2abdc3dcf978 ("dt-bindings: clock: renesas,cpg-clocks: Document ZT/ZTR trace clock on R-Mobile APE6")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Applied for rc1.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-06-24 13:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-23 19:25 [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example Marek Vasut
2026-05-23 19:40 ` sashiko-bot
2026-05-25 16:37 ` Conor Dooley
2026-05-25 19:45 ` Marek Vasut
2026-05-25 19:47 ` Conor Dooley
2026-06-24 13:10 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox