Re: [PATCHv2 1/2] dt-bindings: net: altr,socfpga-stmmac: add more interrupts for Agilex5

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema enforces a strict minimum of 17 interrupts for the Agilex5 compatible, breaking validation for existing in-tree device trees that only define 1 interrupt.
--

commit 7df8c6aab116c93fb2cc3131f91a04fdfb5b5ecf
Author: Dinh Nguyen <dinguyen@kernel.org>

dt-bindings: net: altr,socfpga-stmmac: add more interrupts for Agilex5
    
The stmmac hardware on Agilex5 supports 8 TX/RX queue pairs and is
dma-coherent. Update the schema to handle the hardware differences
between SoC variants.
    
Also make 'interrupts' and 'interrupt-names' as required properties.

> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index fc445ad5a1f1a..63084f7623738 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
[ ... ]
> @@ -149,10 +167,36 @@ required:
>    - clocks
>    - clock-names
>    - altr,sysmgr-syscon
> +  - interrupts
> +  - interrupt-names
>  
>  allOf:
>    - $ref: snps,dwmac.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: altr,socfpga-stmmac-agilex5
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 17
> +
> +        interrupt-names:
> +          minItems: 17

[Severity: Medium]
Will this strict minimum break devicetree validation for existing in-tree
device trees?

For example, in arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi, the
existing gmac0 node only defines one interrupt:

    gmac0: ethernet@10810000 {
        compatible = "altr,socfpga-stmmac-agilex5",
                 "snps,dwxgmac-2.10";
        reg = <0x10810000 0x3500>;
        interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
        interrupt-names = "macirq";
        ...

If existing trees don't provide all 17 interrupts, enforcing exactly 17
here will cause dtbs_check to fail. Could minItems be relaxed or should
the existing device trees be updated alongside this change?

> +
> +        dma-coherent: true
> +    else:
> +      properties:
> +        interrupts:
> +          maxItems: 1
> +
> +        interrupt-names:
> +          maxItems: 1
> +
> +        dma-coherent: false
> +
>  unevaluatedProperties: false
>  
>  examples:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629114818.1746410-1-dinguyen@kernel.org?part=1