[PATCH 0/2] Initial support for Qualcomm Hamoa IOT COME board

[PATCH 0/2] Initial support for Qualcomm Hamoa IOT COME board

[Yuanjie Yang]

Introduce the device tree, DT bindings for HAMOA-IOT-COME board.

The system consists of a SoM mounted on a carrier board. The HAMOA-IOT-COME
SoM integrates the core system, including a SiP that contains the SoC and
related components.

The SiP on the HAMOA-IOT-COME SoM is equivalent to the HAMOA-IOT-EVK SoM.

┌───────────────────────────────┐
│          SoM (Module)         │
│   System on Module (small     │
│   pluggable board)            │
│                               │
│   ┌───────────────────────┐   │
│   │        SiP            │   │
│   │   System in Package   │   │
│   │        (chip)         │   │
│   │                       │   │
│   │   ┌───────────────┐   │   │
│   │   │     SoC       │   │   │
│   │   │               │   │   │
│   │   └───────────────┘   │   │
│   │                       │   │
│   │                       │   │
│   └───────────────────────┘   │
│                               │
└──────────────┬────────────────┘
               │ Plugs into
┌──────────────▼────────────────┐
│   Carrier Board (COME)        │
│                               │
└───────────────────────────────┘


Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
---

Yuanjie Yang (2):
  dt-bindings: arm: qcom: Document HAMOA-IOT-COME board
  arm64: dts: qcom: Add base HAMOA-IOT-COME board

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/hamoa-iot-come-sip.dtsi     |   9 ++
 .../boot/dts/qcom/hamoa-iot-come-som.dtsi     |  38 ++++++
 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts   | 108 ++++++++++++++++++
 5 files changed, 157 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts


base-commit: 7de6ae9e12207ec146f2f3f1e58d1a99317e88bc
-- 
2.43.0

[PATCH 1/2] dt-bindings: arm: qcom: Document HAMOA-IOT-COME board

[Yuanjie Yang]

Document the device tree binding for the HAMOA-IOT-COME board, which uses
the Qualcomm X1E80100 SoC.

The system consists of a SoM mounted on a carrier board. The HAMOA-IOT-COME
SoM integrates the core system, including a SiP that contains the SoC and
related components.

Hierarchy:

    Carrier Board
        -> SoM
            -> SiP
                -> SoC

The SiP on the HAMOA-IOT-COME SoM is equivalent to the HAMOA-IOT-EVK SoM.

Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 50cc18a6ec5e..a487b9e8dfb9 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1172,6 +1172,7 @@ properties:
 
       - items:
           - enum:
+              - qcom,hamoa-iot-come
               - qcom,hamoa-iot-evk
           - const: qcom,hamoa-iot-som
           - const: qcom,x1e80100
-- 
2.43.0

[PATCH 2/2] arm64: dts: qcom: Add base HAMOA-IOT-COME board

[Yuanjie Yang]

Add the device tree for the HAMOA-IOT-COME platform.

The system consists of a SoM mounted on a carrier board. The HAMOA-IOT-COME
SoM integrates the core system, including a SiP that contains the SoC and
related components.

Hierarchy:

    Carrier Board
        -> SoM
            -> SiP
                -> SoC

The SiP on the HAMOA-IOT-COME SOM is equivalent to the HAMOA-IOT-EVK SoM.

The initial device tree includes support for:
- UART
- Regulators
- USB
- PCIe
- Pinctrl
- ADSP, CDSP
- UFS
- Graphic
- Video

Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/hamoa-iot-come-sip.dtsi     |   9 ++
 .../boot/dts/qcom/hamoa-iot-come-som.dtsi     |  38 ++++++
 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts   | 108 ++++++++++++++++++
 4 files changed, 156 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6f33c4e2f09c..549287e3eeba 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -16,6 +16,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096sg-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= eliza-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= glymur-crd.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-come.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
 
 hamoa-iot-evk-el2-dtbs	:= hamoa-iot-evk.dtb x1-el2.dtbo
diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
new file mode 100644
index 000000000000..935af96c2b85
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "hamoa-iot-som.dtsi"
+
+/ {
+};
diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
new file mode 100644
index 000000000000..5c6475b34cc6
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "hamoa-iot-come-sip.dtsi"
+
+/ {
+	vph_pwr: regulator-vph-pwr {
+		compatible = "regulator-fixed";
+
+		regulator-name = "vph_pwr";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		regulator-always-on;
+		regulator-boot-on;
+	};
+};
+
+&ufs_mem_phy {
+	vdda-phy-supply = <&vreg_l3i_0p8>;
+	vdda-pll-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&ufs_mem_hc {
+	reset-gpios = <&tlmm 238 GPIO_ACTIVE_LOW>;
+
+	vcc-supply = <&vreg_l17b_2p5>;
+	vcc-max-microamp = <1300000>;
+	vccq-supply = <&vreg_l2i_1p2>;
+	vccq-max-microamp = <1200000>;
+
+	status = "okay";
+};
+
diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
new file mode 100644
index 000000000000..99c47cd953b8
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
@@ -0,0 +1,108 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "hamoa-iot-come-som.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. Hamoa IoT ComE";
+	compatible = "qcom,hamoa-iot-come", "qcom,hamoa-iot-som", "qcom,x1e80100";
+	chassis-type = "embedded";
+
+	aliases {
+		serial0 = &uart21;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	vreg_pcie_12v: regulator-pcie-12v {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_PCIE_12V";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+
+		gpio = <&pm8550ve_8_gpios 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&pcie_x8_12v>;
+		pinctrl-names = "default";
+	};
+
+	vreg_pcie_3v3: regulator-pcie-3v3 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_PCIE_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&pmc8380_3_gpios 6 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&pm_sde7_main_3p3_en>;
+		pinctrl-names = "default";
+	};
+
+	vreg_pcie_3v3_aux: regulator-pcie-3v3-aux {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_PCIE_3P3_AUX";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&pmc8380_3_gpios 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&pm_sde7_aux_3p3_en>;
+		pinctrl-names = "default";
+	};
+};
+
+&pcie3_port0 {
+	vpcie12v-supply = <&vreg_pcie_12v>;
+	vpcie3v3-supply = <&vreg_pcie_3v3>;
+	vpcie3v3aux-supply = <&vreg_pcie_3v3_aux>;
+
+	reset-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>;
+};
+
+&pm8550ve_8_gpios {
+	pcie_x8_12v: pcie-12v-default-state {
+		pins = "gpio8";
+		function = "normal";
+		output-enable;
+		output-high;
+		bias-pull-down;
+		power-source = <0>;
+	};
+};
+
+&pmc8380_3_gpios {
+	pm_sde7_aux_3p3_en: pcie-aux-3p3-default-state {
+		pins = "gpio8";
+		function = "normal";
+		output-enable;
+		bias-pull-down;
+		power-source = <0>;
+	};
+
+	pm_sde7_main_3p3_en: pcie-main-3p3-default-state {
+		pins = "gpio6";
+		function = "normal";
+		output-enable;
+		bias-pull-down;
+		power-source = <0>;
+	};
+};
+
+&uart21 {
+	compatible = "qcom,geni-debug-uart";
+
+	status = "okay";
+};
-- 
2.43.0

Re: [PATCH 2/2] arm64: dts: qcom: Add base HAMOA-IOT-COME board

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unused PCIe controllers (pcie4, pcie5, pcie6a) are left enabled in the ComE carrier board, causing boot delays and power waste.
--

commit 5654913fbfd858b8d2bf4684318b0d7145c8a5b6
Author: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>

arm64: dts: qcom: Add base HAMOA-IOT-COME board

This commit adds the device tree for the HAMOA-IOT-COME platform, which
consists of a SoM mounted on a carrier board. It includes initial support
for components like UART, Regulators, USB, PCIe, Pinctrl, and UFS.

> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
> new file mode 100644
> index 0000000000000..99c47cd953b83
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
[ ... ]
> +&pcie3_port0 {
> +	vpcie12v-supply = <&vreg_pcie_12v>;
> +	vpcie3v3-supply = <&vreg_pcie_3v3>;
> +	vpcie3v3aux-supply = <&vreg_pcie_3v3_aux>;
> +
> +	reset-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>;
> +	wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>;
> +};

[Severity: Medium]
The included hamoa-iot-som.dtsi enables pcie4, pcie5, and pcie6a with
status = "okay", but this carrier board does not disable them or provide
the required reset-gpios routing.

Will this result in the pcie-qcom driver powering on their PHYs and timing
out during link training?

It appears dw_pcie_wait_for_link() will loop and time out after 900ms per
controller without a connected device or toggled reset signal. This causes
boot delays of nearly 2.7 seconds and leaves unused PHYs powered on.

Should these unused controllers be explicitly disabled here with
status = "disabled"?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630071022.3256-1-yuanjie.yang@oss.qualcomm.com?part=2

Re: [PATCH 2/2] arm64: dts: qcom: Add base HAMOA-IOT-COME board

[yuanjiey]

On Tue, Jun 30, 2026 at 07:26:06AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Unused PCIe controllers (pcie4, pcie5, pcie6a) are left enabled in the ComE carrier board, causing boot delays and power waste.
> --
> 
> commit 5654913fbfd858b8d2bf4684318b0d7145c8a5b6
> Author: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> 
> arm64: dts: qcom: Add base HAMOA-IOT-COME board
> 
> This commit adds the device tree for the HAMOA-IOT-COME platform, which
> consists of a SoM mounted on a carrier board. It includes initial support
> for components like UART, Regulators, USB, PCIe, Pinctrl, and UFS.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
> > new file mode 100644
> > index 0000000000000..99c47cd953b83
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
> [ ... ]
> > +&pcie3_port0 {
> > +	vpcie12v-supply = <&vreg_pcie_12v>;
> > +	vpcie3v3-supply = <&vreg_pcie_3v3>;
> > +	vpcie3v3aux-supply = <&vreg_pcie_3v3_aux>;
> > +
> > +	reset-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>;
> > +	wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>;
> > +};
> 
> [Severity: Medium]
> The included hamoa-iot-som.dtsi enables pcie4, pcie5, and pcie6a with
> status = "okay", but this carrier board does not disable them or provide
> the required reset-gpios routing.
> 
> Will this result in the pcie-qcom driver powering on their PHYs and timing
> out during link training?
> 
> It appears dw_pcie_wait_for_link() will loop and time out after 900ms per
> controller without a connected device or toggled reset signal. This causes
> boot delays of nearly 2.7 seconds and leaves unused PHYs powered on.
> 
> Should these unused controllers be explicitly disabled here with
> status = "disabled"?

Yes, Hamoa COMe does not include NVMe, Bluetooth, or Wi‑Fi,
So I think PCIe 4.0, 5.0, and 6.0 are not required. try to explicitly disabled in
DT is a way
 
Thanks,
Yuanjie


> [ ... ]
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260630071022.3256-1-yuanjie.yang@oss.qualcomm.com?part=2

Re: [PATCH 1/2] dt-bindings: arm: qcom: Document HAMOA-IOT-COME board

[Krzysztof Kozlowski]

On Tue, Jun 30, 2026 at 03:10:11PM +0800, Yuanjie Yang wrote:
> Document the device tree binding for the HAMOA-IOT-COME board, which uses
> the Qualcomm X1E80100 SoC.
> 
> The system consists of a SoM mounted on a carrier board. The HAMOA-IOT-COME
> SoM integrates the core system, including a SiP that contains the SoC and

This is contradictory to the code. Your binding said you are using IOT
SoM, not IoT COME SoM.

> related components.
> 
> Hierarchy:
> 
>     Carrier Board
>         -> SoM
>             -> SiP
>                 -> SoC

Drop. Compatibles define that.

> 
> The SiP on the HAMOA-IOT-COME SoM is equivalent to the HAMOA-IOT-EVK SoM.

I don't even know what does it mean. How two different hardware can be
equivalent? Are they the same? Are you creating duplicated compatibles
for same hardware?

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: Add base HAMOA-IOT-COME board

[Krzysztof Kozlowski]

On Tue, Jun 30, 2026 at 03:10:12PM +0800, Yuanjie Yang wrote:
> Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/hamoa-iot-come-sip.dtsi     |   9 ++
>  .../boot/dts/qcom/hamoa-iot-come-som.dtsi     |  38 ++++++
>  arch/arm64/boot/dts/qcom/hamoa-iot-come.dts   | 108 ++++++++++++++++++
>  4 files changed, 156 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 6f33c4e2f09c..549287e3eeba 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -16,6 +16,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096sg-db820c.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= eliza-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= glymur-crd.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-come.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
>  
>  hamoa-iot-evk-el2-dtbs	:= hamoa-iot-evk.dtb x1-el2.dtbo
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
> new file mode 100644
> index 000000000000..935af96c2b85
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi

What is the point of this file?

> @@ -0,0 +1,9 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include "hamoa-iot-som.dtsi"
> +
> +/ {
> +};

It is completely empty.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: Document HAMOA-IOT-COME board

[yuanjiey]

On Wed, Jul 01, 2026 at 09:28:41AM +0200, Krzysztof Kozlowski wrote:
> On Tue, Jun 30, 2026 at 03:10:11PM +0800, Yuanjie Yang wrote:
> > Document the device tree binding for the HAMOA-IOT-COME board, which uses
> > the Qualcomm X1E80100 SoC.
> > 
> > The system consists of a SoM mounted on a carrier board. The HAMOA-IOT-COME
> > SoM integrates the core system, including a SiP that contains the SoC and
> 
> This is contradictory to the code. Your binding said you are using IOT
> SoM, not IoT COME SoM.

Hierarchy:

Hamoa ComE
 Carrier Board
     -> SoM
         -> SiP(This SiP hardware is effectively the same as the SoM on the Hamoa EVK)
             -> SoC

Hamoa evk
 Carrier Board
     -> SoM
         -> SoC


So I think I write a wrong dt binding about Hamoa ComE:
correct here:
I think the binding should be: 

1.
      - items:
          - enum:
              - qcom,hamoa-iot-come
          - const: qcom,hamoa-iot-come-som
          - const: qcom,hamoa-iot-come-sip
          - const: qcom,x1e80100

or
2.
      - items:
          - enum:
              - qcom,hamoa-iot-come
          - const: qcom,hamoa-iot-come-som
          - const: qcom,hamoa-iot-som
          - const: qcom,x1e80100


> > related components.
> > 
> > Hierarchy:
> > 
> >     Carrier Board
> >         -> SoM
> >             -> SiP
> >                 -> SoC
> 
> Drop. Compatibles define that.

Sure , will do.

> > 
> > The SiP on the HAMOA-IOT-COME SoM is equivalent to the HAMOA-IOT-EVK SoM.
> 
> I don't even know what does it mean. How two different hardware can be
> equivalent? Are they the same? Are you creating duplicated compatibles
> for same hardware?

This ComE SiP hardware is effectively the same as the SoM on the Hamoa EVK, 
It's just called differently on a different board. I should update my
commit msg show this.

> Best regards,
> Krzysztof
> 
Thanks,
Yuanjie

Re: [PATCH 2/2] arm64: dts: qcom: Add base HAMOA-IOT-COME board

[yuanjiey]

On Wed, Jul 01, 2026 at 09:29:34AM +0200, Krzysztof Kozlowski wrote:
> On Tue, Jun 30, 2026 at 03:10:12PM +0800, Yuanjie Yang wrote:
> > Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >  .../boot/dts/qcom/hamoa-iot-come-sip.dtsi     |   9 ++
> >  .../boot/dts/qcom/hamoa-iot-come-som.dtsi     |  38 ++++++
> >  arch/arm64/boot/dts/qcom/hamoa-iot-come.dts   | 108 ++++++++++++++++++
> >  4 files changed, 156 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
> >  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
> >  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 6f33c4e2f09c..549287e3eeba 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -16,6 +16,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096sg-db820c.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= eliza-mtp.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= glymur-crd.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-come.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
> >  
> >  hamoa-iot-evk-el2-dtbs	:= hamoa-iot-evk.dtb x1-el2.dtbo
> > diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
> > new file mode 100644
> > index 000000000000..935af96c2b85
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
> 
> What is the point of this file?

This SiP hardware is effectively the same as the SoM on the Hamoa EVK.
It's just called differently on a different board. I want to use this
file to include hamoa-iot-som.dtsi header to show this idea.

Thanks,
Yuanjie

> > @@ -0,0 +1,9 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + */
> > +
> > +#include "hamoa-iot-som.dtsi"
> > +
> > +/ {
> > +};
> 
> It is completely empty.
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 2/2] arm64: dts: qcom: Add base HAMOA-IOT-COME board

[Krzysztof Kozlowski]

On 01/07/2026 10:51, yuanjiey wrote:
> On Wed, Jul 01, 2026 at 09:29:34AM +0200, Krzysztof Kozlowski wrote:
>> On Tue, Jun 30, 2026 at 03:10:12PM +0800, Yuanjie Yang wrote:
>>> Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>>>  .../boot/dts/qcom/hamoa-iot-come-sip.dtsi     |   9 ++
>>>  .../boot/dts/qcom/hamoa-iot-come-som.dtsi     |  38 ++++++
>>>  arch/arm64/boot/dts/qcom/hamoa-iot-come.dts   | 108 ++++++++++++++++++
>>>  4 files changed, 156 insertions(+)
>>>  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
>>>  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come-som.dtsi
>>>  create mode 100644 arch/arm64/boot/dts/qcom/hamoa-iot-come.dts
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>>> index 6f33c4e2f09c..549287e3eeba 100644
>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>> @@ -16,6 +16,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8096sg-db820c.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)	+= eliza-mtp.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)	+= glymur-crd.dtb
>>> +dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-come.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
>>>  
>>>  hamoa-iot-evk-el2-dtbs	:= hamoa-iot-evk.dtb x1-el2.dtbo
>>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
>>> new file mode 100644
>>> index 000000000000..935af96c2b85
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-come-sip.dtsi
>>
>> What is the point of this file?
> 
> This SiP hardware is effectively the same as the SoM on the Hamoa EVK.
> It's just called differently on a different board. I want to use this
> file to include hamoa-iot-som.dtsi header to show this idea.

You do not need empty file for such purpose.

Best regards,
Krzysztof