Devicetree
 help / color / mirror / Atom feed
* [PATCH v3 0/2] arm64: dts: imx8mp-skov: add new 7" variant
@ 2026-07-01  8:30 Steffen Trumtrar
  2026-07-01  8:30 ` [PATCH v3 1/2] dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant Steffen Trumtrar
  2026-07-01  8:30 ` [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board Steffen Trumtrar
  0 siblings, 2 replies; 6+ messages in thread
From: Steffen Trumtrar @ 2026-07-01  8:30 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Steffen Trumtrar, devicetree, linux-kernel, imx, linux-arm-kernel

Add a new board variant for the Skov i.MX8MP based family of boards.

This variant uses a different 7" panel than the existing ones.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
Changes in v3:
- rebase to v7.2-rc1
- Link to v2: https://patch.msgid.link/20260427-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v2-0-e2b79fc24391@pengutronix.de

Changes in v2:
- rebase to v7.1-rc1
- Link to v1: https://patch.msgid.link/20260325-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v1-0-10255d236439@pengutronix.de

To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Shawn Guo <shawnguo@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
To: Pengutronix Kernel Team <kernel@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org

---
Steffen Trumtrar (2):
      dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant
      arm64: dts: imx8mp-skov: support new 7inch panel board

 Documentation/devicetree/bindings/arm/fsl.yaml     |  1 +
 arch/arm64/boot/dts/freescale/Makefile             |  1 +
 .../imx8mp-skov-revc-jutouch-jt070tm041.dts        | 79 ++++++++++++++++++++++
 3 files changed, 81 insertions(+)
---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260325-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-3dbcb450a39c

Best regards,
--  
Steffen Trumtrar <s.trumtrar@pengutronix.de>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 1/2] dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant
  2026-07-01  8:30 [PATCH v3 0/2] arm64: dts: imx8mp-skov: add new 7" variant Steffen Trumtrar
@ 2026-07-01  8:30 ` Steffen Trumtrar
  2026-07-01 17:07   ` Conor Dooley
  2026-07-01  8:30 ` [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board Steffen Trumtrar
  1 sibling, 1 reply; 6+ messages in thread
From: Steffen Trumtrar @ 2026-07-01  8:30 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Steffen Trumtrar, devicetree, linux-kernel, imx, linux-arm-kernel

In preparation for adding a new device tree variant with a different 7"
panel, describe the DT compatible in the binding.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 86876311ec59a..402f140fb5170 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1147,6 +1147,7 @@ properties:
               - skov,imx8mp-skov-revb-mi1010ait-1cp1 # SKOV i.MX8MP climate control with 10.1" panel
               - skov,imx8mp-skov-revc-hdmi # SKOV i.MX8MP climate control without panel
               - skov,imx8mp-skov-revc-bd500 # SKOV i.MX8MP climate control with LED frontplate
+              - skov,imx8mp-skov-revc-jutouch-jt070tm041 # SKOV i.MX8MP climate control with 7" JuTouch panel
               - skov,imx8mp-skov-revc-jutouch-jt101tm023 # SKOV i.MX8MP climate control with 10" JuTouch panel
               - skov,imx8mp-skov-revc-tian-g07017 # SKOV i.MX8MP climate control with 7" panel
               - ultratronik,imx8mp-ultra-mach-sbc # Ultratronik SBC i.MX8MP based board

-- 
2.51.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board
  2026-07-01  8:30 [PATCH v3 0/2] arm64: dts: imx8mp-skov: add new 7" variant Steffen Trumtrar
  2026-07-01  8:30 ` [PATCH v3 1/2] dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant Steffen Trumtrar
@ 2026-07-01  8:30 ` Steffen Trumtrar
  2026-07-01  8:45   ` sashiko-bot
  1 sibling, 1 reply; 6+ messages in thread
From: Steffen Trumtrar @ 2026-07-01  8:30 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Steffen Trumtrar, devicetree, linux-kernel, imx, linux-arm-kernel

This board is similar to the already upstream
imx8mp-skov-revc-tian-g07017.dts but uses a different 7" panel with a
different touch controller.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/Makefile             |  1 +
 .../imx8mp-skov-revc-jutouch-jt070tm041.dts        | 79 ++++++++++++++++++++++
 2 files changed, 80 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 8ddaab127ab9c..efca29735b2cb 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -435,6 +435,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-bd500.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-hdmi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-tian-g07017.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt070tm041.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt101tm023.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-toradex-smarc-dev.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts
new file mode 100644
index 0000000000000..56374f1e67663
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts
@@ -0,0 +1,79 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+
+/dts-v1/;
+
+#include "imx8mp-skov-reva.dtsi"
+
+/ {
+	model = "SKOV IMX8MP CPU revC - JuTouch JT070TM041";
+	compatible = "skov,imx8mp-skov-revc-jutouch-jt070tm041", "fsl,imx8mp";
+
+	panel {
+		compatible = "jutouch,jt070tm041";
+		backlight = <&backlight>;
+		power-supply = <&reg_tft_vcom>;
+
+		port {
+			in_lvds0: endpoint {
+				remote-endpoint = <&ldb_lvds_ch0>;
+			};
+		};
+	};
+};
+
+&backlight {
+	status = "okay";
+};
+
+&i2c2 {
+	clock-frequency = <100000>;
+	status = "okay";
+
+	touchscreen@2a {
+		compatible = "eeti,exc81w32";
+		reg = <0x2a>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_touchscreen>;
+		interrupts-extended = <&gpio4 28 IRQ_TYPE_LEVEL_LOW>;
+		reset-gpios = <&gpio4 29 GPIO_ACTIVE_LOW>;
+		touchscreen-size-x = <1024>;
+		touchscreen-size-y = <600>;
+		vdd-supply = <&reg_vdd_3v3>;
+	};
+};
+
+&lcdif2 {
+	status = "okay";
+};
+
+&lvds_bridge {
+	assigned-clocks = <&clk IMX8MP_CLK_MEDIA_LDB>,
+				 <&clk IMX8MP_VIDEO_PLL1>;
+	assigned-clock-parents = <&clk IMX8MP_VIDEO_PLL1_OUT>;
+	/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 2 * 7 */
+	assigned-clock-rates = <0>, <358400000>;
+	status = "okay";
+
+	ports {
+		port@1 {
+			ldb_lvds_ch0: endpoint {
+				remote-endpoint = <&in_lvds0>;
+			};
+		};
+	};
+};
+
+&pwm4 {
+	status = "okay";
+};
+
+&pwm1 {
+	status = "okay";
+};
+
+&reg_tft_vcom {
+	regulator-min-microvolt = <3160000>;
+	regulator-max-microvolt = <3160000>;
+	voltage-table = <3160000 73>;
+	status = "okay";
+};

-- 
2.51.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board
  2026-07-01  8:30 ` [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board Steffen Trumtrar
@ 2026-07-01  8:45   ` sashiko-bot
  2026-07-01 15:00     ` Frank Li
  0 siblings, 1 reply; 6+ messages in thread
From: sashiko-bot @ 2026-07-01  8:45 UTC (permalink / raw)
  To: Steffen Trumtrar; +Cc: conor+dt, devicetree, imx, Frank.Li, robh

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] DT Schema Validation Failure: missing fallback compatible string for touchscreen.
- [Low] Documentation error in LVDS clock calculation comment.
- [Low] Makefile Ordering Violation.
--

commit 3b909b83ea0bf98186df799556b414671ad39311
Author: Steffen Trumtrar <s.trumtrar@pengutronix.de>

arm64: dts: imx8mp-skov: support new 7inch panel board
    
This board is similar to the already upstream
imx8mp-skov-revc-tian-g07017.dts but uses a different 7" panel with a
different touch controller.

> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 8ddaab127ab9c..efca29735b2cb 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile

[ ... ]

> @@ -435,6 +435,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-bd500.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-hdmi.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-tian-g07017.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt070tm041.dtb

[Severity: Low]
This isn't a bug, but should this new entry be sorted alphabetically?
Placing jutouch after tian breaks the expected ordering in the Makefile.

>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt101tm023.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-toradex-smarc-dev.dtb

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts
> new file mode 100644
> index 0000000000000..56374f1e67663
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts

[ ... ]

> +&i2c2 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	touchscreen@2a {
> +		compatible = "eeti,exc81w32";

[Severity: Low]
Does this compatible string also require the fallback string eeti,exc80h84
to pass dtbs_check validation? The schema for the eeti,exc3000 touchscreen
typically expects both strings to be present.

> +		reg = <0x2a>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touchscreen>;

[ ... ]

> +&lvds_bridge {
> +	assigned-clocks = <&clk IMX8MP_CLK_MEDIA_LDB>,
> +				 <&clk IMX8MP_VIDEO_PLL1>;
> +	assigned-clock-parents = <&clk IMX8MP_VIDEO_PLL1_OUT>;
> +	/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 2 * 7 */

[Severity: Low]
This isn't a bug, but is the * 2 multiplier in this comment correct?

With the single-link pixel clock of 51.2 MHz for this panel and the assigned
rate of 358400000 Hz, the calculation appears to be exactly 51.2 MHz * 7.
Including the * 2 multiplier would result in 716.8 MHz instead.

> +	assigned-clock-rates = <0>, <358400000>;
> +	status = "okay";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v3-0-d74f7e3f8293@pengutronix.de?part=2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board
  2026-07-01  8:45   ` sashiko-bot
@ 2026-07-01 15:00     ` Frank Li
  0 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2026-07-01 15:00 UTC (permalink / raw)
  To: sashiko-reviews
  Cc: Steffen Trumtrar, conor+dt, devicetree, imx, Frank.Li, robh

On Wed, Jul 01, 2026 at 08:45:00AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [Low] DT Schema Validation Failure: missing fallback compatible string for touchscreen.
> - [Low] Documentation error in LVDS clock calculation comment.
> - [Low] Makefile Ordering Violation.
> --
>
> commit 3b909b83ea0bf98186df799556b414671ad39311
> Author: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>
> arm64: dts: imx8mp-skov: support new 7inch panel board
>
> This board is similar to the already upstream
> imx8mp-skov-revc-tian-g07017.dts but uses a different 7" panel with a
> different touch controller.
>
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 8ddaab127ab9c..efca29735b2cb 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
>
> [ ... ]
>
> > @@ -435,6 +435,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-bd500.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-hdmi.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-tian-g07017.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt070tm041.dtb
>
> [Severity: Low]
> This isn't a bug, but should this new entry be sorted alphabetically?
> Placing jutouch after tian breaks the expected ordering in the Makefile.

Please fix this even Severity is low.

>
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt101tm023.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-toradex-smarc-dev.dtb
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts
> > new file mode 100644
> > index 0000000000000..56374f1e67663
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts
>
> [ ... ]
>
> > +&i2c2 {
> > +	clock-frequency = <100000>;
> > +	status = "okay";
> > +
> > +	touchscreen@2a {
> > +		compatible = "eeti,exc81w32";
>
> [Severity: Low]
> Does this compatible string also require the fallback string eeti,exc80h84
> to pass dtbs_check validation? The schema for the eeti,exc3000 touchscreen
> typically expects both strings to be present.
>
> > +		reg = <0x2a>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_touchscreen>;
>
> [ ... ]
>
> > +&lvds_bridge {
> > +	assigned-clocks = <&clk IMX8MP_CLK_MEDIA_LDB>,
> > +				 <&clk IMX8MP_VIDEO_PLL1>;
> > +	assigned-clock-parents = <&clk IMX8MP_VIDEO_PLL1_OUT>;
> > +	/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 2 * 7 */
>
> [Severity: Low]
> This isn't a bug, but is the * 2 multiplier in this comment correct?
>
> With the single-link pixel clock of 51.2 MHz for this panel and the assigned
> rate of 358400000 Hz, the calculation appears to be exactly 51.2 MHz * 7.
> Including the * 2 multiplier would result in 716.8 MHz instead.

Is AI correct?

Frank
>
> > +	assigned-clock-rates = <0>, <358400000>;
> > +	status = "okay";
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260701-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v3-0-d74f7e3f8293@pengutronix.de?part=2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant
  2026-07-01  8:30 ` [PATCH v3 1/2] dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant Steffen Trumtrar
@ 2026-07-01 17:07   ` Conor Dooley
  0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2026-07-01 17:07 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	devicetree, linux-kernel, imx, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-07-01 17:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-01  8:30 [PATCH v3 0/2] arm64: dts: imx8mp-skov: add new 7" variant Steffen Trumtrar
2026-07-01  8:30 ` [PATCH v3 1/2] dt-bindings: arm: fsl: add compatible for new Skov I.MX8MP variant Steffen Trumtrar
2026-07-01 17:07   ` Conor Dooley
2026-07-01  8:30 ` [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board Steffen Trumtrar
2026-07-01  8:45   ` sashiko-bot
2026-07-01 15:00     ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox