Re: [PATCH v2 2/3] regulator: qcom_usb_vbus: add support for qcom,pm4125-vbus-reg

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The macro `PM4125_VBOOST_CFG` is defined twice with conflicting values (`0x52` and `0x56`), causing the voltage selector to write to the wrong register and corrupt the OTG configuration.
--

commit 3778477cc88a05791ed34dc272e50cbdb4893643
Author: Rakesh Kota <rakesh.kota@oss.qualcomm.com>

regulator: qcom_usb_vbus: add support for qcom,pm4125-vbus-reg

The PM4125 PMIC uses a different register layout for USB VBUS control
compared to PM8150B. On PM4125, CMD_OTG is at offset 0x50, OTG_CFG is
at 0x56, and offset 0x52 is a 2-bit VBOOST voltage selector rather than
a current-limit selector. Introduce per-compatible regulator descriptor
data to accommodate these differences.

> diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
> index cd94ed67621fe..40e7e5589d5b4 100644
> --- a/drivers/regulator/qcom_usb_vbus-regulator.c
> +++ b/drivers/regulator/qcom_usb_vbus-regulator.c
> @@ -20,10 +20,35 @@
>  #define OTG_CFG				0x53
>  #define OTG_EN_SRC_CFG			BIT(1)
>  
> +#define PM4125_VBOOST_EN		0x50
> +#define PM4125_VBOOST_CFG		0x52
> +#define PM4125_VBOOST_CFG_MASK		GENMASK(1, 0)
> +#define PM4125_VBOOST_CFG		0x56

[Severity: High]
Will this redefine PM4125_VBOOST_CFG to 0x56 and silently override the
intended 0x52 offset?

When pm4125_data.vsel_reg is assigned PM4125_VBOOST_CFG, it appears the
regulator core will write to 0x56 instead of the 0x52 VBOOST selector
register.

Should the 0x56 definition be named PM4125_OTG_CFG instead?

> +#define PM4125_OTG_EN_SRC_CFG		BIT(0)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-add_pm4125-vbus-reg-v2-0-6bac2bac7131@oss.qualcomm.com?part=2