Devicetree
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, jishnu.prakash@oss.qualcomm.com,
	kamal.wadhwa@oss.qualcomm.com
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints
Date: Thu, 2 Jul 2026 17:10:08 +0100	[thread overview]
Message-ID: <4de2970b-884d-47e2-ba52-514f973f14b9@kernel.org> (raw)
In-Reply-To: <20260702080228.tegosnl6uwt5hy7c@hu-kotarake-hyd.qualcomm.com>

On 02/07/2026 09:02, Rakesh Kota wrote:
>> Break this patch up at the and
>>
>> - Remove compatible
>> - Fix the voltages
>>
>> Separate things should be separate patches.
>>
> Thanks for the review.
> 
> We kept these together to avoid intermediate breakage since the .yaml
> compatible removal and voltage fix are coupled. Happy to split if you
> have a suggestion on how to do so cleanly.
> 
> regards
> Rakesh Kota

You can add the register abstraction logic, then add the new compatible no ?

---
bod

      reply	other threads:[~2026-07-02 16:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 10:28 [PATCH v2 0/3] regulator: qcom_usb_vbus: add pm4125 VBUS regulator support Rakesh Kota
2026-07-01 10:28 ` [PATCH v2 1/3] dt-bindings: regulator: qcom,usb-vbus-regulator: add qcom,pm4125-vbus-reg Rakesh Kota
2026-07-01 10:28 ` [PATCH v2 2/3] regulator: qcom_usb_vbus: add support for qcom,pm4125-vbus-reg Rakesh Kota
2026-07-01 10:34   ` sashiko-bot
2026-07-02  7:54     ` Rakesh Kota
2026-07-02 12:59       ` Dmitry Baryshkov
2026-07-01 11:25   ` Konrad Dybcio
2026-07-01 11:28   ` Bryan O'Donoghue
2026-07-02  7:51     ` Rakesh Kota
2026-07-01 10:28 ` [PATCH v2 3/3] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints Rakesh Kota
2026-07-01 10:34   ` sashiko-bot
2026-07-02  7:25     ` Rakesh Kota
2026-07-01 11:26   ` Konrad Dybcio
2026-07-02  7:33     ` Rakesh Kota
2026-07-02 12:07       ` Konrad Dybcio
2026-07-02 12:43         ` Rakesh Kota
2026-07-02 13:01           ` Dmitry Baryshkov
2026-07-01 11:29   ` Bryan O'Donoghue
2026-07-02  8:02     ` Rakesh Kota
2026-07-02 16:10       ` Bryan O'Donoghue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4de2970b-884d-47e2-ba52-514f973f14b9@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox