From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, jishnu.prakash@oss.qualcomm.com,
kamal.wadhwa@oss.qualcomm.com
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints
Date: Wed, 1 Jul 2026 13:26:11 +0200 [thread overview]
Message-ID: <83cdc9dd-65d2-48c0-b172-d66f513b9c74@oss.qualcomm.com> (raw)
In-Reply-To: <20260701-add_pm4125-vbus-reg-v2-3-6bac2bac7131@oss.qualcomm.com>
On 7/1/26 12:28 PM, Rakesh Kota wrote:
> Remove pm8150b fallback compatible from pm4125_vbus and fix regulator
> constraints in qrb2210 DTS files to use microvolt instead of
> microamp.
>
> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pm4125.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 4 ++--
> arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm4125.dtsi b/arch/arm64/boot/dts/qcom/pm4125.dtsi
> index 542e8fe030da40dfefc7b744dcc30133fdb35e74..3dc8d667d091ceb4267081d32b7aae983fc25071 100644
> --- a/arch/arm64/boot/dts/qcom/pm4125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm4125.dtsi
> @@ -37,7 +37,7 @@ pm4125_resin: resin {
> };
>
> pm4125_vbus: usb-vbus-regulator@1100 {
> - compatible = "qcom,pm4125-vbus-reg", "qcom,pm8150b-vbus-reg";
> + compatible = "qcom,pm4125-vbus-reg";
> reg = <0x1100>;
> status = "disabled";
> };
> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> index bf088fa9807f040f0c8f405f9111b01790b09377..2b50f3f577577d30a87fcb6466c7d7690270aaa3 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> @@ -235,8 +235,8 @@ &mdss_dsi0_phy {
> };
>
> &pm4125_vbus {
> - regulator-min-microamp = <500000>;
> - regulator-max-microamp = <500000>;
> + regulator-min-microvolt = <4250000>;
> + regulator-max-microvolt = <5000000>;
Perhaps that's a stupid question, but is there any good reason to
not just keep it at 5V if enabled?
Konrad
next prev parent reply other threads:[~2026-07-01 11:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 10:28 [PATCH v2 0/3] regulator: qcom_usb_vbus: add pm4125 VBUS regulator support Rakesh Kota
2026-07-01 10:28 ` [PATCH v2 1/3] dt-bindings: regulator: qcom,usb-vbus-regulator: add qcom,pm4125-vbus-reg Rakesh Kota
2026-07-01 10:28 ` [PATCH v2 2/3] regulator: qcom_usb_vbus: add support for qcom,pm4125-vbus-reg Rakesh Kota
2026-07-01 10:34 ` sashiko-bot
2026-07-02 7:54 ` Rakesh Kota
2026-07-02 12:59 ` Dmitry Baryshkov
2026-07-01 11:25 ` Konrad Dybcio
2026-07-01 11:28 ` Bryan O'Donoghue
2026-07-02 7:51 ` Rakesh Kota
2026-07-01 10:28 ` [PATCH v2 3/3] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints Rakesh Kota
2026-07-01 10:34 ` sashiko-bot
2026-07-02 7:25 ` Rakesh Kota
2026-07-01 11:26 ` Konrad Dybcio [this message]
2026-07-02 7:33 ` Rakesh Kota
2026-07-02 12:07 ` Konrad Dybcio
2026-07-02 12:43 ` Rakesh Kota
2026-07-02 13:01 ` Dmitry Baryshkov
2026-07-01 11:29 ` Bryan O'Donoghue
2026-07-02 8:02 ` Rakesh Kota
2026-07-02 16:10 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cdc9dd-65d2-48c0-b172-d66f513b9c74@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox