Re: [PATCH v6 12/12] ARM: dts: zte: Declare zx297520v3 CRM device nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The fixed-clock device tree node names do not follow the standard `clock-<freq>` naming pattern, which violates schema constraints.
--

commit c7fd353d8042fade42cfb7f95e466ced8cd9112a
Author: Stefan Dösinger <stefandoesinger@gmail.com>

ARM: dts: zte: Declare zx297520v3 CRM device nodes

This commit adds device tree nodes for the zx297520v3 topcrm, matrixcrm, and 
lspcrm controllers. It replaces the placeholder uartclk with fixed-clocks and
wires up the clocks and resets for the UART devices.

> diff --git a/arch/arm/boot/dts/zte/zx297520v3.dtsi b/arch/arm/boot/dts/zte/zx297520v3.dtsi
> index a16c30a164bb9..e3f698e28b498 100644
> --- a/arch/arm/boot/dts/zte/zx297520v3.dtsi
> +++ b/arch/arm/boot/dts/zte/zx297520v3.dtsi

[ ... ]

> @@ -20,13 +22,16 @@ cpu@0 {
>  		};
>  	};
>  
> -	/* Base bus clock and default for the UART. It will be replaced once a clock driver has
> -	 * been added.
> -	 */
> -	uartclk: uartclk-26000000 {
> -		#clock-cells = <0>;
> +	osc26m: osc26m {
>  		compatible = "fixed-clock";
>  		clock-frequency = <26000000>;
> +		#clock-cells = <0>;
> +	};

[Severity: Low]
Will this node name trigger device tree schema validation warnings?

The fixed-clock schema in Documentation/devicetree/bindings/clock/fixed-clock.yaml
marks arbitrary node names as deprecated and expects the pattern clock-<freq>.
Should this be named clock-26000000 instead of osc26m?

> +
> +	osc32k: osc32k {
> +		compatible = "fixed-clock";
> +		clock-frequency = <32768>;
> +		#clock-cells = <0>;
>  	};

[Severity: Low]
Similarly here, should this node be named clock-32768 to conform to the
fixed-clock schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-zx29clk-v6-0-377b704f80c4@gmail.com?part=12