Re: [PATCH v4 1/3] remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `kaanapali_soccp_resource` lacks the newly introduced `.needs_tzmem = true` flag, causing SHM bridge setup failures or SMMU faults for the Kaanapali SoCCP remoteproc.
--

commit 1e9c4b8af0b2474dac8304d92f260e1af8817ef5
Author: Ananthu C V <ananthu.cv@oss.qualcomm.com>

remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation

This commit adds a needs_tzmem flag to ensure tzmem and SHM bridge setup is
performed independently of the iommu property. This is intended to prevent
SMMU faults for remoteprocs that are already running, like SoCCP.

> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 60a4337d9e516..cd7273fbcf981 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c

[ ... ]

> @@ -1657,8 +1658,27 @@ static const struct qcom_pas_data kaanapali_soccp_resource = {
>  	.early_boot = true,
>  };

[Severity: High]
Should kaanapali_soccp_resource also set .needs_tzmem = true?

The commit message explicitly states that for remoteprocs that are already
running like SoCCP, the OS must use needs_tzmem to configure tzmem
independently of the iommus property to avoid SMMU faults. 

Since kaanapali_soccp_resource is also a SoCCP remoteproc, will omitting
this flag here cause SMMU faults or fail to perform the required SHM bridge
setup when probing the qcom,kaanapali-soccp-pas device?

> +static const struct qcom_pas_data glymur_soccp_resource = {
> +	.crash_reason_smem = 656,
> +	.firmware_name = "soccp.mbn",
> +	.dtb_firmware_name = "soccp_dtb.mbn",
> +	.pas_id = 51,
> +	.dtb_pas_id = 0x41,
> +	.proxy_pd_names = (char*[]){
> +		"cx",
> +		"mx",
> +		NULL
> +	},
> +	.ssr_name = "soccp",
> +	.sysmon_name = "soccp",
> +	.auto_boot = true,
> +	.early_boot = true,
> +	.needs_tzmem = true,
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com?part=1