Re: [PATCH v4 2/3] arm64: dts: qcom: fix SoCCP memory mappings for Glymur

[Ananthu C V <ananthu.cv@oss.qualcomm.com>]

On Fri, Jul 03, 2026 at 12:37:27PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Device tree nodes in `reserved-memory` are no longer sorted by unit-address.
> --
> 
> commit a19a73590d416c9dc7623921d49433687e8ae84f
> Author: Ananthu C V <ananthu.cv@oss.qualcomm.com>
> arm64: dts: qcom: fix SoCCP memory mappings for Glymur
> 
> This commit updates the SoCCP and SoCCP DTB memory regions to match the
> Glymur v21 memory map release requirements.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> [ ... ]
> > -		soccpdtb_mem: soccpdtb@892e0000 {
> > -			reg = <0x0 0x892e0000 0x0 0x20000>;
> > +		soccpdtb_mem: soccpdtb@89200000 {
> > +			reg = <0x0 0x89200000 0x0 0x20000>;
> >  			no-map;
> >  		};
> >  
> > -		soccp_mem: soccp@89300000 {
> > -			reg = <0x0 0x89300000 0x0 0x400000>;
> > +		soccp_mem: soccp@88e00000 {
> > +			reg = <0x0 0x88e00000 0x0 0x400000>;
> >  			no-map;
> >  		};
> 
> [Severity: Low]
> This isn't a bug, but should these nodes be reordered to maintain ascending
> unit-address order?
> 
> By changing the addresses here, soccpdtb@89200000 now structurally appears
> before soccp@88e00000, which breaks the conventional ascending sort order
> for reserved-memory nodes.

Indeed, this has been an oversight. I will spin up a revision later to address
this.

> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com?part=2