Re: [PATCH v4 3/3] arm64: dts: qcom: add SoCCP DT node for Glymur

[Ananthu C V <ananthu.cv@oss.qualcomm.com>]

On Fri, Jul 03, 2026 at 12:41:28PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing fallback compatible string for qcom,glymur-soccp-pas.
> --
> 
> commit 13add5a1ca37328da1883f3c5d77042558d05a52
> Author: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> 
> arm64: dts: qcom: add SoCCP DT node for Glymur
>     
> The SoC Control Processor (SoCCP) is a small RISC-V MCU that controls
> USB Type-C, battery charging and various other functions on Qualcomm SoCs.
> This commit adds the PAS loader for SoCCP on the Glymur DT.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > index 5f44f68efde27..bc259dfbaf0e5 100644
> > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> 
> [ ... ]
> 
> > @@ -2297,6 +2297,50 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ALWAYS>,
> >  			};
> >  		};
> >  
> > +		remoteproc_soccp: remoteproc@d00000 {
> > +			compatible = "qcom,glymur-soccp-pas";
> [Severity: Low]
> Should this compatible string include the "qcom,kaanapali-soccp-pas" fallback?
> 
> Without the fallback string mandated by the device tree bindings schema, this
> might cause dtbs_check validation warnings or failures during the build.

Thanks, this will also be addressed in the next revision.

> > +			reg = <0x0 0x00d00000 0x0 0x200000>;
> > +
> > +			interrupts-extended = <&intc GIC_SPI 167 IRQ_TYPE_EDGE_RISING>,
> 
> [ ... ]
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260703-glymur-soccp-v4-0-b706c4c9b3e2@oss.qualcomm.com?part=3