Re: [PATCH 07/10] dt-bindings: i2c: apple,i2c: Add t8132 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'apple,t8132-aic3' (and 'apple,t6030-aic3') compatible strings are omitted from the if-then conditional block that defines the '#interrupt-cells' constraints.
--

commit 0a172829316de760c58e58c389ee943615b44f94
Author: Yureka Lilian <yureka@cyberchaos.dev>

dt-bindings: i2c: apple,i2c: Add t8132 compatible
    
The i2c block on the Apple silicon t8132 (M4) SoC is compatible with the
existing driver. Add "apple,t8132-i2c" as SoC specific compatible under
"apple,t8103-i2c" used by the driver.

> diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> index 9e59200ad37b6..8ce77258e2e5b 100644
> --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> @@ -25,6 +25,7 @@ properties:
>            - enum:
>                - apple,t6020-i2c
>                - apple,t8122-i2c
> +              - apple,t8132-i2c
>            - const: apple,t8103-i2c

[Severity: Low]
Is there a related regression in the interrupt controller bindings for this
SoC generation in:
Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml?

Looking at the conditional block that defines the constraints:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - apple,t8112-aic
              - apple,t8122-aic3
    then:
      properties:
        '#interrupt-cells':
          const: 3

Are the 'apple,t8132-aic3' (and 'apple,t6030-aic3') compatible strings omitted
from this if-then conditional block that defines the '#interrupt-cells'
constraints?

Failing to include new generational strings in existing conditional blocks
can cause schema validation to be incomplete.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705-apple-m4-initial-devicetrees-v1-0-e5655ee56523@cyberchaos.dev?part=7