Re: [PATCH 04/10] dt-bindings: arm: apple: apple,pmgr: Add t8132 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new 'apple,t8132-aic3' compatible was omitted from the conditional block enforcing the '#interrupt-cells' constraint.
--

commit 4be0e67c14a594eec020638f7ba5290c4bf05496
Author: Yureka Lilian <yureka@cyberchaos.dev>

dt-bindings: interrupt-controller: apple,aic2: Add apple,t8132 compatible

The Apple t8132 (M4) SoC uses an AIC3 as interrupt controller, same as
the M3 predecessor.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> index d0d9a90e96e7b..7171c8c09feaf 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -44,6 +44,7 @@ properties:
>        - items:
>            - enum:
>                - apple,t6030-aic3
> +              - apple,t8132-aic3

[Severity: Medium]
Does this new compatible string also need to be added to the conditional block
that enforces the '#interrupt-cells' constraint?

According to the dt-bindings subsystem guide, omitting a generational
compatible string from an existing 'if' block when the hardware shares the
same constraints is a regression that allows invalid configurations to
silently pass schema validation.

Without updating the block, a device tree using 'apple,t8132-aic3' could
potentially provide the wrong number of interrupts or miss properties and
still pass validation:

Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml:
allOf:
  - $ref: /schemas/interrupt-controller.yaml#
  - if:
      properties:
        compatible:
          contains:
            enum:
              - apple,t8112-aic
              - apple,t8122-aic3
    then:
      properties:
        '#interrupt-cells':
          const: 3

Are we missing an update in this if-block for apple,t8132-aic3?

>            - const: apple,t8122-aic3
>        - const: apple,t8122-aic3
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705-apple-m4-initial-devicetrees-v1-0-e5655ee56523@cyberchaos.dev?part=4