Re: [PATCH 09/10] dt-bindings: arm: apple: Add M4 based devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The top-level text description block in the binding was not updated to list the new M4 devices.
- [Low] The inline comments for the newly added M4 MacBook Air models incorrectly label them as 'M3'.
--

commit 2d1ae3586bee901cafa8ffc62c9df52d3acdcf89
Author: Yureka Lilian <yureka@cyberchaos.dev>

dt-bindings: arm: apple: Add M4 based devices

This commit adds compatible strings for Apple M4-based devices. It introduces
the apple,t8132 SoC and associated platforms like the new MacBook Pro, iMac,
MacBook Air, and Mac mini.

Looking at the top-level description block in this file:

Documentation/devicetree/bindings/arm/apple.yaml:
  Devices based on the "M3" SoC:

  - MacBook Air (13-inch, M3, 2024)
  - MacBook Air (15-inch, M3, 2024)
  - MacBook Pro (14-inch, M3, 2023)
  - iMac (24-inch, M3, 2023)

  Devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs:

[Severity: Low]
Should the new M4 devices be added to this top-level description block to
keep the documentation in sync with the schema definition below?


> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> index e49403c73f9d2..3262292252d25 100644
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -315,6 +315,18 @@ properties:
>            - const: apple,t8122
>            - const: apple,arm-platform
>  
> +      - description: Apple M4 SoC based platforms
> +        items:
> +          - enum:
> +              - apple,j604  # MacBook Pro (14-inch, M4, 2024)
> +              - apple,j623  # iMac (24-inch, 2x USB-C, M4, 2024)
> +              - apple,j624  # iMac (24-inch, 4x USB-C, M4, 2024)
> +              - apple,j713  # MacBook Air (13-inch, M3, 2025)
> +              - apple,j715  # MacBook Air (15-inch, M3, 2025)

[Severity: Low]
Are these inline comments correct, or should they say M4 instead of M3 for
the new 2025 MacBook Air models?

> +              - apple,j773g # Mac mini (M4, 2024)
> +          - const: apple,t8132
> +          - const: apple,arm-platform

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705-apple-m4-initial-devicetrees-v1-0-e5655ee56523@cyberchaos.dev?part=9