* [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller
@ 2026-06-30 22:05 Nitin Rawat
2026-07-06 6:43 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Nitin Rawat @ 2026-06-30 22:05 UTC (permalink / raw)
To: krzk+dt, robh, andersson, mani, alim.akhtar, bvanassche,
avri.altman, conor+dt
Cc: linux-arm-msm, linux-kernel, devicetree, linux-scsi, Nitin Rawat
Document the UFS Controller on Maili SoC.
Signed-off-by: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
---
Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
index b441f0d26081..fea89e522f35 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
@@ -18,6 +18,7 @@ select:
- qcom,eliza-ufshc
- qcom,hawi-ufshc
- qcom,kaanapali-ufshc
+ - qcom,maili-ufshc
- qcom,nord-ufshc
- qcom,sm8650-ufshc
- qcom,sm8750-ufshc
@@ -31,6 +32,7 @@ properties:
- qcom,eliza-ufshc
- qcom,hawi-ufshc
- qcom,kaanapali-ufshc
+ - qcom,maili-ufshc
- qcom,nord-ufshc
- qcom,sm8650-ufshc
- qcom,sm8750-ufshc
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller
2026-06-30 22:05 [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller Nitin Rawat
@ 2026-07-06 6:43 ` Krzysztof Kozlowski
2026-07-14 6:31 ` Nitin Rawat
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 6:43 UTC (permalink / raw)
To: Nitin Rawat
Cc: krzk+dt, robh, andersson, mani, alim.akhtar, bvanassche,
avri.altman, conor+dt, linux-arm-msm, linux-kernel, devicetree,
linux-scsi
On Wed, Jul 01, 2026 at 03:35:36AM +0530, Nitin Rawat wrote:
> Document the UFS Controller on Maili SoC.
>
> Signed-off-by: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Why is MMIO address space size flexible here?
A few previous Maili bindings had the same problem - your Claude vibe
coding just looks at one piece and you do not review but trust that LLM.
So again the same comments as other Maili bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller
2026-07-06 6:43 ` Krzysztof Kozlowski
@ 2026-07-14 6:31 ` Nitin Rawat
0 siblings, 0 replies; 3+ messages in thread
From: Nitin Rawat @ 2026-07-14 6:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: krzk+dt, robh, andersson, mani, alim.akhtar, bvanassche,
avri.altman, conor+dt, linux-arm-msm, linux-kernel, devicetree,
linux-scsi
On 7/6/2026 12:13 PM, Krzysztof Kozlowski wrote:
> On Wed, Jul 01, 2026 at 03:35:36AM +0530, Nitin Rawat wrote:
>> Document the UFS Controller on Maili SoC.
>>
>> Signed-off-by: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
>> ---
>> Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> Why is MMIO address space size flexible here?
>
> A few previous Maili bindings had the same problem - your Claude vibe
> coding just looks at one piece and you do not review but trust that LLM.
>
> So again the same comments as other Maili bindings.
Thanks for catching this. Since Maili supports both MCQ and STD register
regions, I'll add 'qcom,maili-ufshc' in v2 to the allOf condition that
enforces minItems: 2 for reg and reg-names for MCQ targets.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-14 6:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 22:05 [PATCH V1] scsi: ufs: dt-bindings: Document the Maili UFS Controller Nitin Rawat
2026-07-06 6:43 ` Krzysztof Kozlowski
2026-07-14 6:31 ` Nitin Rawat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox