Re: [PATCH v4 3/5] dt-bindings: media: qcom: Add JPEG encoder binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `power-domains` property is missing from the binding's properties list and the example, despite being a hardware requirement and functionally necessary for OPP scaling.
--

commit a2cb92d2a69d2918ed65e723421db5b5ac1f0d1f
Author: Atanas Filipov <atanas.filipov@oss.qualcomm.com>

dt-bindings: media: qcom: Add JPEG encoder binding

Adds a device-tree binding for the Qualcomm JPEG encoder hardware block
present in SM8250 (Kona) SoCs.

> diff --git a/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> new file mode 100644
> index 0000000000000..e4c16388ef079
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> @@ -0,0 +1,151 @@
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,sm8250-jenc

[Severity: High]
The commit message states the hardware has its own power domain, but the
power-domains property is missing from this properties block.

Since additionalProperties is set to false, any device tree attempting to
specify the power-domains property will fail schema validation. Should
power-domains be added to the properties list?

[ ... ]
> +        iommus = <&apps_smmu 0x2040 0x400>;
> +
> +        operating-points-v2 = <&jpeg_opp_table>;
> +
> +        jpeg_opp_table: opp-table {
> +            compatible = "operating-points-v2";
> +
> +            opp-100000000 {
> +                opp-hz = /bits/ 64 <400000000>,
> +                         /bits/ 64 <100000000>;
> +                opp-peak-kBps = <76800 104166 104166>;
> +                opp-avg-kBps = <38400 33569 33569>;
> +                required-opps = <&rpmhpd_opp_min_svs>;
> +            };

[Severity: High]
Does this example node need to include the power-domains property?

The example defines required-opps for performance states, but omits the
power-domains property that links the device to the power domain provider.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706071113.383215-1-atanas.filipov@oss.qualcomm.com?part=3