Re: [PATCH v4 2/5] dt-bindings: media: qcom,sm8250-camss: allow JPEG encoder child node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Changing `additionalProperties: false` to `unevaluatedProperties: false` without defining `patternProperties` or a bus `$ref` will still reject child nodes.
--

commit 4a343ca8c275f84ef82003dd286f9fc438eb243e
Author: Atanas Filipov <atanas.filipov@oss.qualcomm.com>

dt-bindings: media: qcom,sm8250-camss: allow JPEG encoder child node

This commit adds bus properties to the CAMSS node binding to support child
IP blocks like the JPEG encoder. It also changes additionalProperties to
unevaluatedProperties to allow child nodes to be validated against their
own schemas.

> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> index a509d4bbcb4aa..6008938ee369d 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
[ ... ]
> @@ -317,7 +325,7 @@ required:
>    - vdda-phy-supply
>    - vdda-pll-supply
>  
> -additionalProperties: false
> +unevaluatedProperties: false

[Severity: Medium]
Does changing additionalProperties to unevaluatedProperties actually allow
child nodes without defining patternProperties or a bus $ref?

When unevaluatedProperties is set to false without a mechanism to evaluate
the child nodes in this schema, won't dtbs_check still reject device trees
containing the newly added jpeg-encoder child node?

>  
>  examples:
>    - |

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706071113.383215-1-atanas.filipov@oss.qualcomm.com?part=2