Re: [PATCH v3 1/6] dtc: dt-check-style: Narrow disallowing of tab in DTS only to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit renames the function `check_tab_in_dts` to `check_tab_in_yaml_example` to resolve confusion, but fails to update the user-facing rule name `'tab-in-dts'`. This introduces an inconsistency between the internal function name and the rule string.
--

commit 9c825da9bb864c8e87cb2f6ad98274fc217a08b7
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Narrow disallowing of tab in DTS only to YAML
    
This commit narrows the scope of the tab-in-dts style check to only apply 
to YAML files. It renames the internal checking function to avoid confusion 
since regular DTS files do allow tabs.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 2d5723d41ea39..34e0f7e2a57a4 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style

[ ... ]

> @@ -929,7 +929,7 @@ RULES = [
>           check_trailing_whitespace),
>      Rule('tab-in-dts', 'relaxed',

[Severity: Low]
Should the user-facing rule name 'tab-in-dts' be updated here as well? 

Since this string is printed in warnings when a tab is found in a YAML example, 
leaving it as 'tab-in-dts' might still cause the same confusion this patch aims 
to resolve. Changing it to something like 'tab-in-yaml' might better align with 
the new function name.

>           'YAML examples may not contain tab characters',
> -         check_tab_in_dts, applies_to=('yaml',)),
> +         check_tab_in_yaml_example, applies_to=('yaml',)),
>      Rule('mixed-indent-chars', 'relaxed',
>           'indent must not mix tabs and spaces',
>           check_mixed_indent_chars),

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-dts-style-checker-v3-0-03ffacff9226@oss.qualcomm.com?part=1