Re: [PATCH v3 6/6] dtc: dt-check-style: Handle properly DTC-style includes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The regular expression `re_dtc_directive` fails to match `/include/` directives that omit trailing whitespace before the quoted filename, leaving the original false-positive indent warnings unfixed for such cases.
--

commit d544e9f7ca01b23db8faca49c7b36dba2a77d032
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Handle properly DTC-style includes

This commit updates dt-check-style to properly handle DTC-style include
directives to avoid false positive indent warnings.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 3c1aa9e28347e..b8ba6dbee86d5 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -49,6 +49,9 @@ re_cpp_directive = re.compile(
>      r'^#\s*(include|define|undef|ifdef|ifndef|if|else|elif|endif|'
>      r'pragma|error|warning)\b')
>  
> +re_dtc_directive = re.compile(
> +    r'^/(dts-v1|include)/[;\s]')

[Severity: Low]
Does this regular expression miss valid /include/ directives that omit trailing
whitespace before the quoted filename?

If a .dts file contains a directive without a space, such as
/include/"file.dtsi", it is not matched by re_dtc_directive because it lacks a
space or semicolon. This could cause the script to treat it as an incomplete
property, bypassing the brace depth tracking and triggering the exact false
positive this patch aims to fix.

Should the character class be expanded to include double quotes, such as
[;\s"]?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-dts-style-checker-v3-0-03ffacff9226@oss.qualcomm.com?part=6