Re: [PATCH v3 4/6] dtc: dt-check-style: Expect first device_type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Docstrings in `dt-check-style` were not fully updated to reflect the new `device_type` canonical order.
--

commit bb6e224694e154bb051ff9fc5122693c0b1a4366
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Expect first device_type

A few nodes do have "device_type" property which is mostly, but not always,
the first property in a device node, when applicable. Adjust the DTS
coding style rules to actually expect the device_type first and improve
the dt-check-style to handle this correctly.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index cf61e92d0568e..d9080297bd4db 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -558,28 +558,31 @@ def check_child_name_order(ctx):
>  
>  def _property_bucket(name):
>      """Return the canonical bucket index for a property:
> -       0 compatible
> -       1 reg / reg-names
> -       2 ranges
> -       3 standard properties (no vendor comma in #-stripped name)
> -       4 vendor-specific properties
> -       5 status
> +       0 device_type
> +       1 compatible
> +       2 reg / reg-names
> +       3 ranges
> +       4 standard properties (no vendor comma in #-stripped name)
> +       5 vendor-specific properties
> +       6 status
>      Plus a sub-key inside the bucket for fixed slots (compatible, reg,
>      reg-names, ranges, status). 'standard' and 'vendor' return None for
>      the sub-key, signalling that the within-bucket key is computed by
>      the pairing rules."""

[Severity: Low]
This isn't a bug, but the explanatory text directly below the list wasn't
updated. Should "device_type" also be added to the enumerated list of
fixed slots in the "(compatible, reg, reg-names, ranges, status)" text?

Also, in check_property_order() further down the file, the docstring
describing the overall canonical property order still starts with
"compatible, reg(/reg-names)..." and misses "device_type". Should that
be updated as well?

>      stripped = name.lstrip('#')
> -    if name == 'compatible':
> +    if name == 'device_type':
>          return (0, 0)
> -    if name == 'reg':
> +    if name == 'compatible':
>          return (1, 0)
> +    if name == 'reg':
> +        return (2, 0)
>      if name == 'reg-names':
> -        return (1, 1)
> +        return (2, 1)
>      if name == 'ranges':
> -        return (2, 0)
> +        return (3, 0)
>      if name == 'status':
> -        return (5, 0)
> -    return (4 if ',' in stripped else 3, None)
> +        return (6, 0)
> +    return (5 if ',' in stripped else 4, None)
>  
>  
>  # Declarative pairing rules: each is a callable

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-dts-style-checker-v3-0-03ffacff9226@oss.qualcomm.com?part=4