From: sashiko-bot@kernel.org
To: "Jie Gan" <jie.gan@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: kaanapali: fix traceNoC probe issue
Date: Tue, 07 Jul 2026 09:21:47 +0000 [thread overview]
Message-ID: <20260707092147.B7B051F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260707-fix-tracenoc-probe-issue-v5-3-bf733ed9ebd0@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete migration of the traceNoC binding leaves the sm8750 device tree violating the updated schema.
--
--- Patch [3]: [PATCH v5 3/5] arm64: dts: qcom: kaanapali: fix traceNoC probe issue ---
commit 9b027ffc45673a64efa19cd6c9d0acb4efe7595e
Author: Jie Gan <jie.gan@oss.qualcomm.com>
arm64: dts: qcom: kaanapali: fix traceNoC probe issue
This commit drops the arm,primecell compatible string from the traceNoC
node in the kaanapali device tree. By doing so, the device binds via the
platform driver rather than the AMBA bus, bypassing the missing primecell CID
and fixing an indefinite deferred probe issue.
> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> index 7aa9653bd456e..5d0e7e8c2e58c 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
[ ... ]
> @@ -5004,7 +5004,7 @@ tpdm_pcie_rscc_out: endpoint {
> };
>
> tn@111b8000 {
> - compatible = "qcom,coresight-tnoc", "arm,primecell";
> + compatible = "qcom,coresight-tnoc";
[Severity: Medium]
Does this incomplete migration leave other device trees violating the updated
binding schema?
If the qcom,coresight-tnoc.yaml binding was modified to strictly accept only
the single qcom,coresight-tnoc string by explicitly dropping arm,primecell,
then arch/arm64/boot/dts/qcom/sm8750.dtsi appears to still retain the old
compatible string:
arch/arm64/boot/dts/qcom/sm8750.dtsi:
compatible = "qcom,coresight-tnoc", "arm,primecell";
Will this cause a make dtbs_check validation failure for sm8750?
> reg = <0x0 0x111b8000 0x0 0x4200>;
>
> clocks = <&aoss_qmp>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-fix-tracenoc-probe-issue-v5-0-bf733ed9ebd0@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-07-07 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 9:08 [PATCH v5 0/5] Fix traceNoC probe issue on multiple QCOM platforms Jie Gan
2026-07-07 9:08 ` [PATCH v5 1/5] dt-bindings: arm: coresight-tnoc: Drop arm,primecell to bind on platform bus Jie Gan
2026-07-07 9:22 ` sashiko-bot
2026-07-09 7:59 ` Krzysztof Kozlowski
2026-07-09 8:34 ` Jie Gan
2026-07-09 8:46 ` Krzysztof Kozlowski
2026-07-09 9:02 ` Jie Gan
2026-07-09 9:17 ` Krzysztof Kozlowski
2026-07-07 9:08 ` [PATCH v5 2/5] coresight: tnoc: Bind Aggregator TNOC on the " Jie Gan
2026-07-07 9:22 ` sashiko-bot
2026-07-07 9:08 ` [PATCH v5 3/5] arm64: dts: qcom: kaanapali: fix traceNoC probe issue Jie Gan
2026-07-07 9:21 ` sashiko-bot [this message]
2026-07-07 9:08 ` [PATCH v5 4/5] arm64: dts: qcom: sm8750: " Jie Gan
2026-07-07 9:30 ` sashiko-bot
2026-07-07 9:08 ` [PATCH v5 5/5] arm64: dts: qcom: glymur: use Aggregator TNOC compatible Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707092147.B7B051F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox