* [PATCH v2 0/4] Add Intel Agilex5 SoCDK TSN Config2 board
@ 2026-07-07 6:13 muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH v2 1/4] dt-bindings: arm: altera: Add " muhammad.nazim.amirul.nazle.asmade
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-07-07 6:13 UTC (permalink / raw)
To: dinguyen, maxime.chevallier
Cc: rmk+kernel, krzk+dt, conor+dt, robh, davem, edumazet, kuba,
pabeni, andrew+netdev, devicetree, linux-arm-kernel, netdev,
linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
v2:
- Replace mac-mode DT property with a board-specific compatible string
"altr,socfpga-stmmac-agilex5-tsn" to identify gmac1 on the TSN Config2
board, per Andrew Lunn's feedback.
- Change phy-mode from "rgmii" to "rgmii-id" on both gmac1 and gmac2,
since the FPGA GMII-to-RGMII converter provides the TX/RX clock delays
(acting as MAC-side delays).
- Add a new patch (3/4) documenting the new MAC compatible string in
the altr,socfpga-stmmac binding.
- Fix DTS Makefile indentation (Krzysztof Kozlowski).
---
This series adds DT binding, device tree, and driver support for the
Intel SoCFPGA Agilex5 SoCDK TSN Config2 board.
The board has two Ethernet ports: gmac2 is a standard RGMII port, while
gmac1 is the TSN port. On gmac1, an FPGA GMII-to-RGMII converter sits
between the MAC and the PHY. This converter provides the RGMII TX/RX
clock delays, so phy-mode is set to "rgmii-id". The driver uses the
new "altr,socfpga-stmmac-agilex5-tsn" compatible to detect this setup
and configure the MAC interface selector for GMII while ensuring the
PHY is not asked to add delays a second time.
Nazim Amirul (4):
dt-bindings: arm: altera: Add Agilex5 SoCDK TSN Config2 board
arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board
dt-bindings: net: altr,socfpga-stmmac: Add
altr,socfpga-stmmac-agilex5-tsn compatible
net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA
converter
.../devicetree/bindings/arm/altera.yaml | 1 +
.../bindings/net/altr,socfpga-stmmac.yaml | 5 +
arch/arm64/boot/dts/intel/Makefile | 1 +
.../intel/socfpga_agilex5_socdk_tsn_cfg2.dts | 131 ++++++++++++++++++
.../ethernet/stmicro/stmmac/dwmac-socfpga.c | 13 +-
5 files changed, 150 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
--
2.43.7
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/4] dt-bindings: arm: altera: Add Agilex5 SoCDK TSN Config2 board
2026-07-07 6:13 [PATCH v2 0/4] Add Intel Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
@ 2026-07-07 6:13 ` muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:41 ` Krzysztof Kozlowski
2026-07-07 6:13 ` [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add " muhammad.nazim.amirul.nazle.asmade
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-07-07 6:13 UTC (permalink / raw)
To: dinguyen, maxime.chevallier
Cc: rmk+kernel, krzk+dt, conor+dt, robh, davem, edumazet, kuba,
pabeni, andrew+netdev, devicetree, linux-arm-kernel, netdev,
linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
Add compatible string for the Intel SoCFPGA Agilex5 SoCDK TSN Config2
board variant. This board enables gmac1 as a TSN port with an FPGA
GMII-to-RGMII converter providing the RGMII clock delays.
Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
Documentation/devicetree/bindings/arm/altera.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 3030cf46fe74..e431469a7175 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -114,6 +114,7 @@ properties:
- intel,socfpga-agilex5-socdk-debug
- intel,socfpga-agilex5-socdk-modular
- intel,socfpga-agilex5-socdk-nand
+ - intel,socfpga-agilex5-socdk-tsn-cfg2
- const: intel,socfpga-agilex5
- description: Agilex72 boards
--
2.43.7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board
2026-07-07 6:13 [PATCH v2 0/4] Add Intel Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH v2 1/4] dt-bindings: arm: altera: Add " muhammad.nazim.amirul.nazle.asmade
@ 2026-07-07 6:13 ` muhammad.nazim.amirul.nazle.asmade
2026-07-08 6:13 ` sashiko-bot
2026-07-07 6:13 ` [PATCH v2 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH net-next v2 4/4] net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA converter muhammad.nazim.amirul.nazle.asmade
3 siblings, 1 reply; 8+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-07-07 6:13 UTC (permalink / raw)
To: dinguyen, maxime.chevallier
Cc: rmk+kernel, krzk+dt, conor+dt, robh, davem, edumazet, kuba,
pabeni, andrew+netdev, devicetree, linux-arm-kernel, netdev,
linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
Add device tree for the Intel SoCFPGA Agilex5 SoCDK TSN Config2 board
variant. This configuration enables gmac1 as a TSN port alongside the
standard gmac2 Ethernet port.
The TSN port (gmac1) connects to its PHY through a GMII-to-RGMII
converter implemented as FPGA soft IP. This converter provides the
RGMII TX/RX clock delays, so phy-mode is set to "rgmii-id" to reflect
MAC-side delays. A board-specific compatible string is used so the
driver can detect the converter and strip the delay bits before
configuring the PHY.
Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
arch/arm64/boot/dts/intel/Makefile | 1 +
.../intel/socfpga_agilex5_socdk_tsn_cfg2.dts | 131 ++++++++++++++++++
2 files changed, 132 insertions(+)
create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
index 270c70fdf084..ce7cf3a63275 100644
--- a/arch/arm64/boot/dts/intel/Makefile
+++ b/arch/arm64/boot/dts/intel/Makefile
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
socfpga_agilex5_socdk_013b.dtb \
socfpga_agilex5_socdk_modular.dtb \
socfpga_agilex5_socdk_nand.dtb \
+ socfpga_agilex5_socdk_tsn_cfg2.dtb \
socfpga_agilex72_socdk.dtb \
socfpga_agilex7m_socdk.dtb \
socfpga_n5x_socdk.dtb
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
new file mode 100644
index 000000000000..bf13ccfc1faa
--- /dev/null
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
@@ -0,0 +1,131 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+#include "socfpga_agilex5.dtsi"
+
+/ {
+ model = "SoCFPGA Agilex5 SoCDK TSN Config2";
+ compatible = "intel,socfpga-agilex5-socdk-tsn-cfg2", "intel,socfpga-agilex5";
+
+ aliases {
+ serial0 = &uart0;
+ ethernet1 = &gmac1;
+ ethernet2 = &gmac2;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led-0 {
+ label = "hps_led0";
+ gpios = <&porta 11 GPIO_ACTIVE_HIGH>;
+ };
+
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ /* We expect the bootloader to fill in the reg */
+ reg = <0x0 0x80000000 0x0 0x0>;
+ };
+};
+
+&gpio0 {
+ status = "okay";
+};
+
+&gpio1 {
+ status = "okay";
+};
+
+&gmac1 {
+ status = "okay";
+ compatible = "altr,socfpga-stmmac-agilex5-tsn",
+ "altr,socfpga-stmmac-agilex5",
+ "snps,dwxgmac-2.10";
+ phy-mode = "rgmii-id";
+ phy-handle = <&emac1_phy0>;
+ max-frame-size = <9000>;
+
+ mdio0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "snps,dwmac-mdio";
+
+ emac1_phy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+ };
+};
+
+&gmac2 {
+ status = "okay";
+ phy-mode = "rgmii-id";
+ phy-handle = <&emac2_phy0>;
+ max-frame-size = <9000>;
+
+ mdio0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "snps,dwmac-mdio";
+
+ emac2_phy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+ };
+};
+
+&osc1 {
+ clock-frequency = <25000000>;
+};
+
+&qspi {
+ status = "okay";
+ flash@0 {
+ compatible = "micron,mt25qu02g", "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <100000000>;
+ m25p,fast-read;
+ cdns,read-delay = <2>;
+ cdns,tshsl-ns = <50>;
+ cdns,tsd2d-ns = <50>;
+ cdns,tchsh-ns = <4>;
+ cdns,tslch-ns = <4>;
+ spi-tx-bus-width = <4>;
+ spi-rx-bus-width = <4>;
+
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ qspi_boot: partition@0 {
+ label = "u-boot";
+ reg = <0x0 0x04200000>;
+ };
+
+ root: partition@4200000 {
+ label = "root";
+ reg = <0x04200000 0x0be00000>;
+ };
+ };
+ };
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ disable-over-current;
+};
+
+&watchdog0 {
+ status = "okay";
+};
--
2.43.7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible
2026-07-07 6:13 [PATCH v2 0/4] Add Intel Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH v2 1/4] dt-bindings: arm: altera: Add " muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add " muhammad.nazim.amirul.nazle.asmade
@ 2026-07-07 6:13 ` muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH net-next v2 4/4] net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA converter muhammad.nazim.amirul.nazle.asmade
3 siblings, 0 replies; 8+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-07-07 6:13 UTC (permalink / raw)
To: dinguyen, maxime.chevallier
Cc: rmk+kernel, krzk+dt, conor+dt, robh, davem, edumazet, kuba,
pabeni, andrew+netdev, devicetree, linux-arm-kernel, netdev,
linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
The Agilex5 SoCDK TSN Config2 board uses a GMII-to-RGMII converter
implemented as FPGA soft IP between gmac1 and its PHY. This converter
provides the RGMII TX/RX clock delays. Document a new compatible string
for this MAC variant so the driver can detect it and configure the
interface accordingly.
Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
.../devicetree/bindings/net/altr,socfpga-stmmac.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index 63084f762373..81f030986fa3 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -24,6 +24,7 @@ select:
- altr,socfpga-stmmac
- altr,socfpga-stmmac-a10-s10
- altr,socfpga-stmmac-agilex5
+ - altr,socfpga-stmmac-agilex5-tsn
required:
- compatible
@@ -46,6 +47,10 @@ properties:
- items:
- const: altr,socfpga-stmmac-agilex5
- const: snps,dwxgmac-2.10
+ - items:
+ - const: altr,socfpga-stmmac-agilex5-tsn
+ - const: altr,socfpga-stmmac-agilex5
+ - const: snps,dwxgmac-2.10
clocks:
minItems: 1
--
2.43.7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH net-next v2 4/4] net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA converter
2026-07-07 6:13 [PATCH v2 0/4] Add Intel Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
` (2 preceding siblings ...)
2026-07-07 6:13 ` [PATCH v2 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible muhammad.nazim.amirul.nazle.asmade
@ 2026-07-07 6:13 ` muhammad.nazim.amirul.nazle.asmade
3 siblings, 0 replies; 8+ messages in thread
From: muhammad.nazim.amirul.nazle.asmade @ 2026-07-07 6:13 UTC (permalink / raw)
To: dinguyen, maxime.chevallier
Cc: rmk+kernel, krzk+dt, conor+dt, robh, davem, edumazet, kuba,
pabeni, andrew+netdev, devicetree, linux-arm-kernel, netdev,
linux-kernel
From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
The Agilex5 SoCDK TSN Config2 board uses a GMII-to-RGMII converter
implemented as FPGA soft IP between gmac1 and its PHY. This converter
provides the RGMII TX/RX clock delays, so the MAC interface selector
must be configured for GMII while the PHY is configured without delays.
Add the "altr,socfpga-stmmac-agilex5-tsn" compatible to the match table
and detect it in probe to force GMII for the MAC interface selector and
strip the delay bits from phy_interface so the PHY is not configured to
add delays already provided by the FPGA converter.
Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index 1d7f0a57d288..bf591a68502f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -69,12 +69,13 @@ struct socfpga_dwmac {
void __iomem *tse_pcs_base;
void __iomem *sgmii_adapter_base;
bool f2h_ptp_ref_clk;
+ phy_interface_t mac_interface;
const struct socfpga_dwmac_ops *ops;
};
static phy_interface_t socfpga_get_plat_phymode(struct socfpga_dwmac *dwmac)
{
- return dwmac->plat_dat->phy_interface;
+ return dwmac->mac_interface;
}
static void socfpga_sgmii_config(struct socfpga_dwmac *dwmac, bool enable)
@@ -650,6 +651,15 @@ static int socfpga_dwmac_probe(struct platform_device *pdev)
plat_dat->pcs_exit = socfpga_dwmac_pcs_exit;
plat_dat->select_pcs = socfpga_dwmac_select_pcs;
+ dwmac->mac_interface = plat_dat->phy_interface;
+
+ if (of_device_is_compatible(pdev->dev.of_node,
+ "altr,socfpga-stmmac-agilex5-tsn")) {
+ dwmac->mac_interface = PHY_INTERFACE_MODE_GMII;
+ if (phy_interface_mode_is_rgmii(plat_dat->phy_interface))
+ plat_dat->phy_interface = PHY_INTERFACE_MODE_RGMII;
+ }
+
ops->setup_plat_dat(dwmac);
return devm_stmmac_pltfr_probe(pdev, plat_dat, &stmmac_res);
@@ -674,6 +684,7 @@ static const struct of_device_id socfpga_dwmac_match[] = {
{ .compatible = "altr,socfpga-stmmac", .data = &socfpga_gen5_ops },
{ .compatible = "altr,socfpga-stmmac-a10-s10", .data = &socfpga_gen10_ops },
{ .compatible = "altr,socfpga-stmmac-agilex5", .data = &socfpga_agilex5_ops },
+ { .compatible = "altr,socfpga-stmmac-agilex5-tsn", .data = &socfpga_agilex5_ops },
{ }
};
MODULE_DEVICE_TABLE(of, socfpga_dwmac_match);
--
2.43.7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: arm: altera: Add Agilex5 SoCDK TSN Config2 board
2026-07-07 6:13 ` [PATCH v2 1/4] dt-bindings: arm: altera: Add " muhammad.nazim.amirul.nazle.asmade
@ 2026-07-07 6:41 ` Krzysztof Kozlowski
2026-07-07 8:08 ` Nazle Asmade, Muhammad Nazim Amirul
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-07 6:41 UTC (permalink / raw)
To: muhammad.nazim.amirul.nazle.asmade, dinguyen, maxime.chevallier
Cc: rmk+kernel, krzk+dt, conor+dt, robh, davem, edumazet, kuba,
pabeni, andrew+netdev, devicetree, linux-arm-kernel, netdev,
linux-kernel
On 07/07/2026 08:13, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>
> Add compatible string for the Intel SoCFPGA Agilex5 SoCDK TSN Config2
> board variant. This board enables gmac1 as a TSN port with an FPGA
> GMII-to-RGMII converter providing the RGMII clock delays.
>
> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
So you just ignored the tag? Sure, we can ignore patches as well.
Dropping from patchwork.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: arm: altera: Add Agilex5 SoCDK TSN Config2 board
2026-07-07 6:41 ` Krzysztof Kozlowski
@ 2026-07-07 8:08 ` Nazle Asmade, Muhammad Nazim Amirul
0 siblings, 0 replies; 8+ messages in thread
From: Nazle Asmade, Muhammad Nazim Amirul @ 2026-07-07 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, dinguyen@kernel.org,
maxime.chevallier@bootlin.com
Cc: rmk+kernel@armlinux.org.uk, krzk+dt@kernel.org,
conor+dt@kernel.org, robh@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
andrew+netdev@lunn.ch, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On 7/7/2026 2:41 pm, Krzysztof Kozlowski wrote:
>> Add compatible string for the Intel SoCFPGA Agilex5 SoCDK TSN Config2
>> board variant. This board enables gmac1 as a TSN port with an FPGA
>> GMII-to-RGMII converter providing the RGMII clock delays.
>>
>> Signed-off-by: Nazim Amirul<muhammad.nazim.amirul.nazle.asmade@altera.com>
> So you just ignored the tag? Sure, we can ignore patches as well.
> Dropping from patchwork.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Apologies for the oversight. In v2 we restructured the series by adding
a new patch for the net MAC binding (altr,socfpga-stmmac), and during
that reorganization we accidentally dropped your Acked-by tag from patch
1/4. This was our mistake and not intentional.
We will carry your Acked-by in v3.
BR,
Nazim
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board
2026-07-07 6:13 ` [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add " muhammad.nazim.amirul.nazle.asmade
@ 2026-07-08 6:13 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-07-08 6:13 UTC (permalink / raw)
To: muhammad.nazim.amirul.nazle.asmade; +Cc: conor+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Broken RGMII timings due to missing driver support for stripping PHY delays.
- [Low] Undocumented MAC-level compatible string.
--
--- Patch [2]: [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board ---
commit 9b347403f48cf7cfca1e37c7a4bbf38717136eeb
Author: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board
This commit adds the device tree for the Intel SoCFPGA Agilex5 SoCDK TSN
Config2 board variant. It enables gmac1 as a TSN port utilizing a
GMII-to-RGMII converter implemented in the FPGA fabric.
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
> new file mode 100644
> index 0000000000000..bf13ccfc1faa5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
[ ... ]
> +&gmac1 {
> + status = "okay";
> + compatible = "altr,socfpga-stmmac-agilex5-tsn",
[Severity: Low]
Is this new MAC-level compatible string documented in the devicetree bindings?
It appears missing from Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml,
which would cause dtbs_check validation to fail with warnings.
> + "altr,socfpga-stmmac-agilex5",
> + "snps,dwxgmac-2.10";
> + phy-mode = "rgmii-id";
[Severity: High]
The commit message states that the new compatible string is used so the driver
can detect the converter and strip the delay bits before configuring the PHY.
Does the dwmac-socfpga driver currently support the
altr,socfpga-stmmac-agilex5-tsn string and the associated delay-stripping
logic?
If this support isn't present in the driver yet, the driver will fall back to
altr,socfpga-stmmac-agilex5 and pass rgmii-id unmodified. Will this cause the
PHY driver to add internal delays on top of the delays already provided by the
FPGA soft IP, resulting in broken RGMII timings?
> + phy-handle = <&emac1_phy0>;
> + max-frame-size = <9000>;
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707061305.27580-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=2
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-07-08 6:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-07 6:13 [PATCH v2 0/4] Add Intel Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH v2 1/4] dt-bindings: arm: altera: Add " muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:41 ` Krzysztof Kozlowski
2026-07-07 8:08 ` Nazle Asmade, Muhammad Nazim Amirul
2026-07-07 6:13 ` [PATCH v2 2/4] arm64: dts: socfpga: agilex5: Add " muhammad.nazim.amirul.nazle.asmade
2026-07-08 6:13 ` sashiko-bot
2026-07-07 6:13 ` [PATCH v2 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible muhammad.nazim.amirul.nazle.asmade
2026-07-07 6:13 ` [PATCH net-next v2 4/4] net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA converter muhammad.nazim.amirul.nazle.asmade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox