Re: [PATCH v3 22/26] remoteproc: qcom: Move minidump data structures into its own header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The newly added header file `include/linux/soc/qcom/minidump.h` uses types `__le32` and `__le64` but fails to include `<linux/types.h>`.
- [Low] The highly generic macro `MAX_REGION_NAME_LENGTH` is exposed in a global header without a proper subsystem-specific prefix.
--

--- Patch [22]: [PATCH v3 22/26] remoteproc: qcom: Move minidump data structures into its own header ---
commit 2cd4dc20742b94f6ee105c751e369816b8d27d0f
Author: Eugen Hristev <ehristev@kernel.org>

remoteproc: qcom: Move minidump data structures into its own header

This commit moves Qualcomm minidump data structures from qcom_common.c to a
new shared header file. This allows the structures to be reused by other
drivers.

> diff --git a/include/linux/soc/qcom/minidump.h b/include/linux/soc/qcom/minidump.h
> new file mode 100644
> index 0000000000000..7449a04e6e158
> --- /dev/null
> +++ b/include/linux/soc/qcom/minidump.h
> @@ -0,0 +1,67 @@
[ ... ]
> +#ifndef __QCOM_MINIDUMP_H__
> +#define __QCOM_MINIDUMP_H__
> +

[Severity: Low]
Does this new header need to include <linux/types.h>? It uses __le32 and
__le64 types below in struct minidump_region, which might cause build
failures if a driver includes this header without previously including the
types header.

> +#define MAX_REGION_NAME_LENGTH  16

[Severity: Low]
This isn't a bug, but moving this macro to a global include directory
exposes a very generic name to the global namespace. Could this cause macro
redefinition collisions with other subsystems? It might be safer to give it
a subsystem-specific prefix.

> +#define SBL_MINIDUMP_SMEM_ID	602
> +#define MINIDUMP_REGION_VALID		('V' << 24 | 'A' << 16 | 'L' << 8 | 'I' << 0)
[ ... ]
> +struct minidump_region {
> +	char	name[MAX_REGION_NAME_LENGTH];
> +	__le32	seq_num;
> +	__le32	valid;
> +	__le64	address;
> +	__le64	size;
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-meminspect-v3-v3-0-7aa5a0a74d5c@oss.qualcomm.com?part=22