Re: [PATCH v3 16/26] kallsyms: Annotate static information into meminspect

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The meminspect regions for kallsyms static arrays are exported with a hardcoded size of `sizeof(void *)`, which severely truncates the exported data.
--

--- Patch [16]: [PATCH v3 16/26] kallsyms: Annotate static information into meminspect ---
commit 06ced28af88b52acf5d6e8d844fee7f21cd5492c
Author: Eugen Hristev <ehristev@kernel.org>

kallsyms: Annotate static information into meminspect

This commit adds annotations for vital kallsyms static arrays into meminspect.
The information includes symbol numbers, offsets, names, and tokens, stored in
a dedicated meminspect section.

> diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
> index aec2f06858afd..e71c085ec837c 100644
> --- a/kernel/kallsyms.c
> +++ b/kernel/kallsyms.c
> @@ -31,9 +31,18 @@
>  #include <linux/kernel.h>
>  #include <linux/bsearch.h>
>  #include <linux/btf_ids.h>
> +#include <linux/meminspect.h>
>  
>  #include "kallsyms_internal.h"
>  
> +MEMINSPECT_SIMPLE_ENTRY(kallsyms_num_syms);
> +MEMINSPECT_AREA_ENTRY(kallsyms_offsets, sizeof(void *));
> +MEMINSPECT_AREA_ENTRY(kallsyms_names, sizeof(void *));
> +MEMINSPECT_AREA_ENTRY(kallsyms_token_table, sizeof(void *));
> +MEMINSPECT_AREA_ENTRY(kallsyms_token_index, sizeof(void *));
> +MEMINSPECT_AREA_ENTRY(kallsyms_markers, sizeof(void *));
> +MEMINSPECT_AREA_ENTRY(kallsyms_seqs_of_names, sizeof(void *));

[Severity: Medium]
Does this hardcoded size truncate the exported data?

By specifying sizeof(void *) (which is 8 bytes on 64-bit systems) for the
size of these arrays, it appears the vast majority of the kallsyms data
will be omitted from the exported meminspect regions.

Should this use the actual size of the arrays instead so diagnostic tools
can resolve symbols properly when reading the meminspect table?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-meminspect-v3-v3-0-7aa5a0a74d5c@oss.qualcomm.com?part=16