Re: [PATCH v3 21/26] printk: Register information into meminspect

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dynamic log buffer is registered into meminspect with a size of 0.
--

--- Patch [21]: [PATCH v3 21/26] printk: Register information into meminspect ---
commit 898d5571e45a9513c93cedd97dbc95171637944b
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

printk: Register information into meminspect

This commit annotates vital static and dynamic printk variables for the
meminspect debugging tool. It registers variables like the dynamic log
buffers and info structures into the meminspect table during setup.

> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 2fe9a963c823a..f7f32c09b9b81 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c

[ ... ]

> @@ -1238,6 +1246,10 @@ void __init setup_log_buf(int early)
>  
>  	local_irq_restore(flags);
>  
> +	meminspect_lock_register_va(new_log_buf, new_log_buf_len);

[Severity: Medium]
Will this register the region with a size of 0?

Looking earlier in setup_log_buf(), new_log_buf_len is explicitly
zeroed out before this call:

	log_buf_len = new_log_buf_len;
	log_buf = new_log_buf;
	new_log_buf_len = 0;

Could this call be changed to use log_buf_len instead so the proper size
is registered?

> +	meminspect_lock_register_va(new_descs, new_descs_size);
> +	meminspect_lock_register_va(new_infos, new_infos_size);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-meminspect-v3-v3-0-7aa5a0a74d5c@oss.qualcomm.com?part=21