Re: [PATCH v4 2/7] dtc: dt-check-style: Allow space-aligning indentation in DTS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `check_mixed_indent_chars` rule silently bypasses property continuation lines, rendering its newly added space-limit validation ineffective for list properties and undermining the patch's stated goal.
--

--- Patch [2]: [PATCH v4 2/7] dtc: dt-check-style: Allow space-aligning indentation in DTS ---
commit 7913e7da3c58b0a74f8737f725c2117139d9183f
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Allow space-aligning indentation in DTS

This commit relaxes the mixed indent check in dt-check-style to allow 
space-aligning indentation in DTS files for comments or continued lines. 
It replaces the strict mixed-indent rule with checks for space-followed-by-tab 
and excessive space counts (more than 7).

v2: https://lore.kernel.org/r/20260706102421.343639-4-krzysztof.kozlowski@oss.qualcomm.com/
v1: https://lore.kernel.org/r/20260706071446.87669-2-krzysztof.kozlowski@oss.qualcomm.com/

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 29b25ecf15c66..5d7765f35ecbc 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -359,14 +359,17 @@ def check_tab_in_yaml_example(ctx):
>  
>  
>  def check_mixed_indent_chars(ctx):
> -    """Indent must be all-spaces or all-tabs, never mixed on one line."""
> +    """Indent must be all-tabs, except for aligning indentation (comments
> +    or continued lines)."""
>      for dl in ctx.lines:

[Severity: Medium]
Does this loop miss checking property continuation lines?

By iterating only over ctx.lines, it appears to skip evaluating 
dl.continuations where property continuations are stored. This prevents the 
newly added space-limit validation from executing for list properties, which 
the rule explicitly claims to check in the docstring.

>          if not dl.indent_str:
>              continue
>          if dl.linetype == LineType.PREPROCESSOR:
>              continue
> -        if ' ' in dl.indent_str and '\t' in dl.indent_str:
> +        if re.search(r' \t', dl.indent_str):
>              yield (dl.lineno, 'mixed tabs and spaces in indent')
> +        if dl.indent_str.count(' ') > 7:
> +            yield (dl.lineno, 'too many space characters in indent (more than 7)')

[ ... ]

> diff --git a/scripts/dtc/dt-style-selftest/bad/dts-mixed-indent.dts b/scripts/dtc/dt-style-selftest/bad/dts-mixed-indent.dts
> new file mode 100644
> index 0000000000000..f0e40cfc910c7
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/bad/dts-mixed-indent.dts
> @@ -0,0 +1,20 @@

[ ... ]

> +		clocks = <1>,
> +			 <2>,
> +		         <3>;

[Severity: Medium]
As a consequence of skipping continuations above, does this line evade the
"more than 7 spaces" check?

This line contains 9 spaces of indentation before the `<3>;`, but because it 
is a property continuation, the tool does not yield the expected warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-dts-style-checker-v4-0-c175e6401150@oss.qualcomm.com?part=2