Re: [PATCH v4 6/7] dtc: dt-check-style: Print proper line number of indentation detection place

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Outdated docstring for detect_indent_unit()
- [Low] Unused variable `lineno` in `check_indent_consistent()`
--

--- Patch [6]: [PATCH v4 6/7] dtc: dt-check-style: Print proper line number of indentation detection place ---
commit 0faea90fe4385d4895b11cc94353072a1a5f9347
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Print proper line number of indentation detection place

Script judges the indentation however always suggests it is the first
line which is wrong, e.g.:

  sigmastar/mstar-infinity2m.dtsi:1: [indent-unit-dts] indent unit must be 1 tab in DTS, got '\t\t'

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 9a5263a30663f..df056e4d0a5b5 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -397,48 +397,48 @@ def detect_indent_unit(ctx):
>          if not dl.indent_str:
>              continue
>          if dl.indent_str == '\t':
> -            return '\t'
> +            return ('\t', dl.lineno)

[Severity: Low]
Is there a documentation regression here?

Looking at the top of detect_indent_unit():
    """Find the indent unit used at depth 1 in this block.

    Returns one of: '  ' (2 spaces), '    ' (4 spaces), '\t' (tab),
    or None if depth-1 is empty or ambiguous."""

Since it now returns a 2-tuple instead, should the docstring be updated to
reflect this change?

[ ... ]

>  def check_indent_consistent(ctx):
>      """All indented lines must be a multiple of the detected unit."""
> -    unit = detect_indent_unit(ctx)
> +    (unit, lineno) = detect_indent_unit(ctx)
>      if unit is None:
>          return
>      if ctx.file_type == 'yaml':

[Severity: Low]
Is there a minor regression here with an unused variable?

It appears lineno is unpacked from the tuple but never used anywhere in
check_indent_consistent().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-dts-style-checker-v4-0-c175e6401150@oss.qualcomm.com?part=6