Re: [PATCH v4 7/7] dtc: dt-check-style: Add more DTS test cases

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing semicolons at the end of node definitions in multiple newly added Device Tree Source (DTS) test cases.
--

--- Patch [7]: [PATCH v4 7/7] dtc: dt-check-style: Add more DTS test cases ---
commit 62a01452b76be437a860d7d26f7c0086f5c3e54e
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Add more DTS test cases

Add a few more test cases for valid and incorrect DTS for
dt-check-style.

> diff --git a/scripts/dtc/dt-style-selftest/bad/dts-child-name-order.dts b/scripts/dtc/dt-style-selftest/bad/dts-child-name-order.dts
> new file mode 100644
> index 0000000000000..dffc81cffbeb5
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/bad/dts-child-name-order.dts

[ ... ]

> +	pmu-2 {
> +		compatible = "example,pmu";
> +
> +		/* Just reference labels to avoid strict warnings */
> +		example,foo = <&foo>, <&label_bar>;
> +	}

[Severity: Low]
Does this node definition need a trailing semicolon? It looks like it ends
with } instead of };.

> +};

> diff --git a/scripts/dtc/dt-style-selftest/bad/dts-extend-node-child-name-order.dts b/scripts/dtc/dt-style-selftest/bad/dts-extend-node-child-name-order.dts
> new file mode 100644
> index 0000000000000..19fb800e719fb
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/bad/dts-extend-node-child-name-order.dts

[ ... ]

> +	pmu {
> +		compatible = "example,pmu";
> +
> +		/* Just reference labels to avoid strict warnings */
> +		example,foo = <&foo>, <&label_bar>;
> +	}

[Severity: Low]
Is a trailing semicolon missing from the pmu node definition?

> +};

[ ... ]

> diff --git a/scripts/dtc/dt-style-selftest/bad/dts-extend-node-digit-node-order.dts b/scripts/dtc/dt-style-selftest/bad/dts-extend-node-digit-node-order.dts
> new file mode 100644
> index 0000000000000..66547a1cd2b5a
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/bad/dts-extend-node-digit-node-order.dts

[ ... ]

> +	serial@30000 {
> +		compatible = "example,serial";
> +		reg = <0x30000 0x1000>;
> +	};
> +}

[Severity: Low]
Should this soc override block end with a semicolon?

> diff --git a/scripts/dtc/dt-style-selftest/good/dts-child-name-order.dts b/scripts/dtc/dt-style-selftest/good/dts-child-name-order.dts
> new file mode 100644
> index 0000000000000..b1032885ad486
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/good/dts-child-name-order.dts

[ ... ]

> +	pmu-2 {
> +		compatible = "example,pmu";
> +
> +		/* Just reference labels to avoid strict warnings */
> +		example,foo = <&foo>, <&label_bar>;
> +	}

[Severity: Low]
Could there be a missing trailing semicolon at the end of this node?

> +};

> diff --git a/scripts/dtc/dt-style-selftest/good/dts-extend-node-child-name-order.dts b/scripts/dtc/dt-style-selftest/good/dts-extend-node-child-name-order.dts
> new file mode 100644
> index 0000000000000..33ce562b72a39
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/good/dts-extend-node-child-name-order.dts

[ ... ]

> +	pmu {
> +		compatible = "example,pmu";
> +
> +		/* Just reference labels to avoid strict warnings */
> +		example,foo = <&foo>, <&label_bar>;
> +	}

[Severity: Low]
Does this node definition also require a semicolon?

> +};

[ ... ]

> diff --git a/scripts/dtc/dt-style-selftest/good/dts-extend-node-digit-node-order.dts b/scripts/dtc/dt-style-selftest/good/dts-extend-node-digit-node-order.dts
> new file mode 100644
> index 0000000000000..d9f1f533beebd
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/good/dts-extend-node-digit-node-order.dts

[ ... ]

> +	serial@30000 {
> +		compatible = "example,serial";
> +		reg = <0x30000 0x1000>;
> +	};
> +}

[Severity: Low]
Should this block end with }; to be a valid Device Tree syntax?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-dts-style-checker-v4-0-c175e6401150@oss.qualcomm.com?part=7