Re: [PATCH net-next v5 05/13] net: ethernet: oa_tc6: Export standard defined registers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Exporting generic macro names (e.g., `CONFIG0_SYNC`, `RESET_SWRESET`) to a global header without a subsystem prefix pollutes the global namespace and risks macro collisions.
--

--- Patch [5]: [PATCH net-next v5 05/13] net: ethernet: oa_tc6: Export standard defined registers ---
commit 4ff73c98efb9b6327cdf6a32eb7febe13e03abfa
Author: Ciprian Regus <ciprian.regus@analog.com>

net: ethernet: oa_tc6: Export standard defined registers

This commit moves definitions for standard Open Alliance TC6 register
addresses and subfields from the driver into the include/linux/oa_tc6.h
header. This allows other ethernet drivers that rely on oa_tc6 to use
them directly.

[ ... ]

> diff --git a/include/linux/oa_tc6.h b/include/linux/oa_tc6.h
> index 2660eefa35043..d99e0f79af84b 100644
> --- a/include/linux/oa_tc6.h
> +++ b/include/linux/oa_tc6.h
> @@ -10,6 +10,56 @@
>  #include <linux/etherdevice.h>
>  #include <linux/spi/spi.h>
>  
> +/* OPEN Alliance TC6 registers */
> +/* Standard Capabilities Register */
> +#define OA_TC6_REG_STDCAP			0x0002
> +#define STDCAP_DIRECT_PHY_REG_ACCESS		BIT(8)
> +
> +/* Reset Control and Status Register */
> +#define OA_TC6_REG_RESET			0x0003
> +#define RESET_SWRESET				BIT(0)	/* Software Reset */
> +
> +/* Configuration Register #0 */
> +#define OA_TC6_REG_CONFIG0			0x0004
> +#define CONFIG0_SYNC				BIT(15)
> +#define CONFIG0_ZARFE_ENABLE			BIT(12)
> +#define CONFIG0_PROTE				BIT(5)

[Severity: Low]
Is it safe to export generic macro names like CONFIG0_SYNC and
RESET_SWRESET to a global header without a subsystem prefix? Could this
pollute the global namespace and cause macro collisions with other drivers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-adin1140-driver-v5-0-4aca7b51a58b@analog.com?part=5