Re: [PATCH net-next v5 12/13] net: phy: Add support for the ADIN1140 PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] adin1140_loopback incorrectly rejects valid loopback speed requests
--

--- Patch [12]: [PATCH net-next v5 12/13] net: phy: Add support for the ADIN1140 PHY ---
commit 55f86668d72d6b8eb4a781fcee866b06847b0a2f
Author: Ciprian Regus <ciprian.regus@analog.com>

net: phy: Add support for the ADIN1140 PHY

Add a driver for the ADIN1140's internal 10BASE-T1S PHY. The device
doesn't implement autonegotiation, so the link is always reported as
being up.

> diff --git a/drivers/net/phy/adin1140-phy.c b/drivers/net/phy/adin1140-phy.c
> new file mode 100644
> index 0000000000000..d35da4ad680da
> --- /dev/null
> +++ b/drivers/net/phy/adin1140-phy.c

[ ... ]

> +static int adin1140_loopback(struct phy_device *phydev, bool enable, int speed)
> +{
> +	if (enable && speed)
> +		return -EOPNOTSUPP;

[Severity: Medium]
Will this correctly handle a valid loopback speed request? If a MAC driver
explicitly passes the PHY's native speed (SPEED_10) when calling
phy_loopback(), this check will evaluate to true and return -EOPNOTSUPP.

Could this instead check if the requested speed is unsupported, rather than
rejecting any non-zero speed?

> +
> +	return phy_modify_mmd(phydev, MDIO_MMD_PCS, ADIN1140_PCS_CTRL,
> +			      ADIN1140_PCS_CTRL_LOOPBACK,
> +			      enable ? ADIN1140_PCS_CTRL_LOOPBACK : 0);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-adin1140-driver-v5-0-4aca7b51a58b@analog.com?part=12