Re: [PATCH net-next v5 04/13] net: ethernet: oa_tc6: Export the C45 access functions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing forward declaration of struct mii_bus in oa_tc6.h
--

--- Patch [4]: [PATCH net-next v5 04/13] net: ethernet: oa_tc6: Export the C45 access functions ---
commit 396791ba4d15eb553624cdae104591b0ddf7be04
Author: Ciprian Regus <ciprian.regus@analog.com>

net: ethernet: oa_tc6: Export the C45 access functions

This commit makes the C45 access functions non-static and exports them so
they can be used by Ethernet drivers which set the OA_TC6_BROKEN_PHY flag.
It also adds the corresponding function prototypes to the oa_tc6.h header.

> diff --git a/include/linux/oa_tc6.h b/include/linux/oa_tc6.h
> index 62e3d89f80ed0..2660eefa35043 100644
> --- a/include/linux/oa_tc6.h
> +++ b/include/linux/oa_tc6.h
> @@ -31,3 +31,7 @@ int oa_tc6_read_registers(struct oa_tc6 *tc6, u32 address, u32 value[],
>  			  u8 length);
>  netdev_tx_t oa_tc6_start_xmit(struct oa_tc6 *tc6, struct sk_buff *skb);
>  int oa_tc6_zero_align_receive_frame_enable(struct oa_tc6 *tc6);
> +int oa_tc6_mdiobus_read_c45(struct mii_bus *bus, int addr, int devnum,
> +			    int regnum);
> +int oa_tc6_mdiobus_write_c45(struct mii_bus *bus, int addr, int devnum,
> +			     int regnum, u16 val);

[Severity: Low]
Is a forward declaration for struct mii_bus needed in this header?

If linux/oa_tc6.h is included in a file without a prior declaration or
include for struct mii_bus, could it cause compiler warnings about the
struct being declared inside a parameter list?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-adin1140-driver-v5-0-4aca7b51a58b@analog.com?part=4