Re: [PATCH net-next v7 01/15] dt-bindings: net: add onsemi's S2500

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Device tree bindings must strictly describe hardware and remain OS-agnostic, but the example codifies an incorrect interrupt trigger type to work around a Linux driver bug.
--

--- Patch [1]: [PATCH net-next v7 01/15] dt-bindings: net: add onsemi's S2500 ---
commit c5ba93a12722287e42d3e9292af727d174c00b8d
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

dt-bindings: net: add onsemi's S2500

Add device tree binding for the onsemi S2500 IEEE 802.3cg compliant Ethernet
transceiver device. The commit notes the use of an edge-falling interrupt
trigger as a workaround for a current framework bug, despite the hardware
specification calling for a level-low trigger.

> diff --git a/Documentation/devicetree/bindings/net/onnn,s2500.yaml b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/onnn,s2500.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethernet@0 {
> +        compatible = "onnn,s2500";
> +        reg = <0>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&eth0_pins>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 IRQ_TYPE_EDGE_FALLING>;

[Severity: Medium]
Device tree bindings are meant to strictly describe the hardware and remain
OS-agnostic. Since the hardware specification calls for a level-low trigger,
does codifying IRQ_TYPE_EDGE_FALLING in the example to work around a Linux 
driver bug risk creating an ABI compatibility issue?

When the framework bug is eventually fixed, device trees based on this 
example might break, or the kernel might have to permanently maintain backward 
compatibility for this incorrect hardware description. Would it be better for
the binding to document the true hardware state (IRQ_TYPE_LEVEL_LOW) instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-s2500-mac-phy-support-v7-0-478c877aa1a9@onsemi.com?part=1